From: Peilin Ye <yepeilin.cs@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: jmaloy@redhat.com, ying.xue@windriver.com, kuba@kernel.org,
hdanton@sina.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel-mentees@lists.linuxfoundation.org,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create_member()
Date: Sun, 13 Sep 2020 03:49:23 -0400 [thread overview]
Message-ID: <20200913074923.GA1533160@PWN> (raw)
In-Reply-To: <20200912.182336.585362420502143240.davem@davemloft.net>
On Sat, Sep 12, 2020 at 06:23:36PM -0700, David Miller wrote:
> From: Peilin Ye <yepeilin.cs@gmail.com>
> Date: Sat, 12 Sep 2020 06:22:30 -0400
>
> > @@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group *grp,
> > else if (key > nkey)
> > n = &(*n)->rb_right;
> > else
> > - return;
> > + return -1;
>
> Use a real error code like "-EEXIST", thank you.
Ah, I'll fix it in v2 soon, sorry about that. I saw another function in
this file returning -1.
Peilin Ye
next prev parent reply other threads:[~2020-09-13 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 2:38 memory leak in tipc_group_create_member syzbot
2019-08-02 12:18 ` Ying Xue
2020-09-12 10:22 ` [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create_member() Peilin Ye
2020-09-13 1:23 ` David Miller
2020-09-13 7:49 ` Peilin Ye [this message]
2020-09-13 8:06 ` [Linux-kernel-mentees] [PATCH net v2] " Peilin Ye
2020-09-14 23:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913074923.GA1533160@PWN \
--to=yepeilin.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).