From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53407C43461 for ; Sun, 13 Sep 2020 09:14:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11AE2207BB for ; Sun, 13 Sep 2020 09:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725935AbgIMJO2 (ORCPT ); Sun, 13 Sep 2020 05:14:28 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:48931 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgIMJOY (ORCPT ); Sun, 13 Sep 2020 05:14:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 57DBB455; Sun, 13 Sep 2020 05:14:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 13 Sep 2020 05:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6caHZu FWNbhXAoG/AuiV8OBLt+yyQM+UA4eajeJzjFE=; b=eV76RELtFhr0evByPB0cet goCUmxIcUC5786rNQTt737LGvLqYthF6CjQydE+cJ+3bRgd6dI6G2/YggP0+ECVN w6e1iKf/HtnKF4dT8MrqDEKX9iQamSEqTkcjJyWIhv/sbSJ6jnksC5t106nM0pV/ Zu1xrVAQxYYAePdCsDQRSQQN+BiqZ+gpPbBJai9urYst6GIifDWhjpzww++4zHXX NXtLFQvj0YlwdW+U6qvanjgwZxUhSlh5MfbiT6bn2CjnqK0bumZ0cF8rpPRMZ8x9 yW3pICavCGjDQ7FUzXSSahqH54HpaXIoHRCHHVnlc9tqFgKj2ZjQISRosfCB+4jw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeifedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepvddtvddrudeigedrvdehrdehnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (unknown [202.164.25.5]) by mail.messagingengine.com (Postfix) with ESMTPA id E0BF7306467D; Sun, 13 Sep 2020 05:14:19 -0400 (EDT) Date: Sun, 13 Sep 2020 12:14:14 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: Alexander Duyck , David Miller , Netdev , Michal Kubecek , Michael Chan , tariqt@nvidia.com, saeedm@nvidia.com, Andrew Lunn Subject: Re: [PATCH net-next 7/8] ixgbe: add pause frame stats Message-ID: <20200913091414.GA3208846@shredder> References: <20200911195258.1048468-1-kuba@kernel.org> <20200911195258.1048468-8-kuba@kernel.org> <20200911151343.25fbbdec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911151343.25fbbdec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 11, 2020 at 03:13:43PM -0700, Jakub Kicinski wrote: > On Fri, 11 Sep 2020 14:12:50 -0700 Alexander Duyck wrote: > > On Fri, Sep 11, 2020 at 12:53 PM Jakub Kicinski wrote: > > > @@ -3546,6 +3556,7 @@ static const struct ethtool_ops ixgbe_ethtool_ops = { > > > .set_eeprom = ixgbe_set_eeprom, > > > .get_ringparam = ixgbe_get_ringparam, > > > .set_ringparam = ixgbe_set_ringparam, > > > + .get_pause_stats = ixgbe_get_pause_stats, > > > .get_pauseparam = ixgbe_get_pauseparam, > > > .set_pauseparam = ixgbe_set_pauseparam, > > > .get_msglevel = ixgbe_get_msglevel, > > > > So the count for this is simpler in igb than it is for ixgbe. I'm > > assuming you want just standard link flow control frames. If so then > > this patch is correct. Otherwise if you are wanting to capture > > priority flow control data then those are a seperate array of stats > > prefixed with a "p" instead of an "l". Otherwise this looks fine to > > me. > > That's my interpretation, although I haven't found any place the > standard would address this directly. Non-PFC pause has a different > opcode, so I'm reasonably certain this makes sense. > > BTW I'm not entirely clear on what "global PFC pause" is either. > > Maybe someone can clarify? Mellanox folks? I checked IEEE 802.1Qaz and could not find anything relevant. My only guess is that it might be a PFC frame with all the priorities set. Where did you see it? > > > Reviewed-by: Alexander Duyck > > Thanks! >