From: Andrew Lunn <andrew@lunn.ch>
To: Edward Cree <ecree@solarflare.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments
Date: Mon, 14 Sep 2020 05:04:25 +0200 [thread overview]
Message-ID: <20200914030425.GG3463198@lunn.ch> (raw)
In-Reply-To: <115bce2a-daaa-a7c5-3c48-44ce345ea008@solarflare.com>
On Sat, Sep 12, 2020 at 12:11:20AM +0100, Edward Cree wrote:
> On 11/09/2020 23:26, Jakub Kicinski wrote:
> > "Toolchain" sounds a little grand in this context, the script that
> > parses kdoc does basic regexps to convert the standard kernel macros:
> > ...
> > IDK if we can expect it to understand random driver's macros..
> I wasn't suggesting it should _understand_ this macro, justrecognise
> when something _is_ a macro it doesn't understand, and refrain from
> warning about it in that case.
Is it possible to get the C preprocessor to expand the macros without
stripping the comments? Run the kerneldoc validator on that?
Andrew
next prev parent reply other threads:[~2020-09-14 3:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:23 [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e Jesse Brandeburg
2020-09-23 2:02 ` [Intel-wired-lan] " Brown, Aaron F
2020-09-11 1:23 ` [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly Jesse Brandeburg
2020-09-11 17:43 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-11 23:28 ` Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments Jesse Brandeburg
2020-09-11 17:16 ` Edward Cree
2020-09-11 1:23 ` [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg
2020-09-11 22:56 ` Jacob Keller
2020-09-11 1:23 ` [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg
2020-09-11 17:26 ` Edward Cree
2020-09-11 21:42 ` Jesse Brandeburg
2020-09-11 21:55 ` Edward Cree
2020-09-11 22:26 ` Jakub Kicinski
2020-09-11 23:11 ` Edward Cree
2020-09-12 0:49 ` Jesse Brandeburg
2020-09-14 3:04 ` Andrew Lunn [this message]
2020-09-11 14:55 ` [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jakub Kicinski
2020-09-11 19:00 ` Jesse Brandeburg
2020-09-11 20:12 ` Jakub Kicinski
2020-09-11 21:34 ` Jesse Brandeburg
2020-09-11 22:16 ` Jakub Kicinski
2020-09-11 22:43 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914030425.GG3463198@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecree@solarflare.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).