From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAF4C433E2 for ; Mon, 14 Sep 2020 09:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 684C7207EA for ; Mon, 14 Sep 2020 09:32:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="a4Zoosb5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgINJcm (ORCPT ); Mon, 14 Sep 2020 05:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbgINJch (ORCPT ); Mon, 14 Sep 2020 05:32:37 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB6AC061788 for ; Mon, 14 Sep 2020 02:32:36 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id lo4so22217483ejb.8 for ; Mon, 14 Sep 2020 02:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S12Ozp3Vsq8tS9g1DhUCy0Z/H/j+wxx4VSfsrHbFWrQ=; b=a4Zoosb5FMCUcX3ko7MzxtqQ5g229ysUK77EQ3rznkAU7ETZQeN15zHk8nOo+RupO/ uWJEqSHNuvgjV3EETWW9l4VUIC3AefmOMGLR5a2r/CmuCH8NSocEKzWnzXu3W2ziXSk5 EIbO/zel0odzIWMASvi+3MrQXncK3d7eC27vev3SYWcf6DOv8LxtHLFKPVdVcB2ezFmK b6kkDZ2HIj0yf65TqIuIwxDDrh47WUqIvwEg5gJ6ZHpuLliNbVIeGGGuLJf3seFmovJK jTB2lu30aOaTH8CDGjxTWU6j4jssjlCXqfvWL5H4Jmc02usJh3Pq7CpHqI3qVoHoP5ph XBrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S12Ozp3Vsq8tS9g1DhUCy0Z/H/j+wxx4VSfsrHbFWrQ=; b=mrwZKziCZ6XPEuXrBlr1r3PpK5H/7B74I7RefQWwAJHeirrXbexHnQHISWl+7SgZvW ovvKSpqPTesdxdkX+ubMsVgBMNL9Mlr/pbMg71bC9iSO4aKuSzWzEfrf/9YcgebXkGb9 JiB5LbE7rfE4ZX2CmsQPH5j5yznhJTvtKE3ay2X9+329dDWbjZE/bNVRcPoVSR5LsXFm uQCrg2xixSYLM7fWpnJe9XznvHhLvy6KjjILXLWPqGL7AqnbZnvR4Rytue9xlMeQcAPC 7G/fmrcJOCQRRkW6J016bQcZKmEZtj0A67gJ0HWPYJ7IxNzT9E0ACKKntA1az++v7DfK nasw== X-Gm-Message-State: AOAM530LGnDQ1WVT8AHvJsP7BIolcAPahPwkINn2kVUkQme3bH5jNkDq rUbWFd2A6K7IbGUgAx/ZYxgepiMqyR5Pt/uh X-Google-Smtp-Source: ABdhPJyBWT+4MuT1smyevpT5Ha/ugeFB0PYXRB0MRJ6FFg7yJ95A9z8gLMYrf983IDj+WcFuT4qUwQ== X-Received: by 2002:a17:906:3ad0:: with SMTP id z16mr14355972ejd.193.1600075955616; Mon, 14 Sep 2020 02:32:35 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id p25sm8848649edm.60.2020.09.14.02.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 02:32:35 -0700 (PDT) Date: Mon, 14 Sep 2020 11:32:34 +0200 From: Jiri Pirko To: Vasundhara Volam Cc: Moshe Shemesh , "David S. Miller" , Jakub Kicinski , Jiri Pirko , Netdev , open list Subject: Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command Message-ID: <20200914093234.GB2236@nanopsycho.orion> References: <1600063682-17313-1-git-send-email-moshe@mellanox.com> <1600063682-17313-2-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Sep 14, 2020 at 09:08:58AM CEST, vasundhara-v.volam@broadcom.com wrote: >On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: [...] >> @@ -1126,15 +1126,24 @@ mlxsw_devlink_core_bus_device_reload_down(struct devlink *devlink, >> } >> >> static int >> -mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink, >> - struct netlink_ext_ack *extack) >> +mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink, enum devlink_reload_action action, >> + struct netlink_ext_ack *extack, >> + unsigned long *actions_performed) >Sorry for repeating again, for fw_activate action on our device, all >the driver entities undergo reset asynchronously once user initiates >"devlink dev reload action fw_activate" and reload_up does not have >much to do except reporting actions that will be/being performed. > >Once reset is complete, the health reporter will be notified using Hmm, how is the fw reset related to health reporter recovery? Recovery happens after some error event. I don't believe it is wise to mix it. Instead, why don't you block in reload_up() until the reset is complete? >devlink_health_reporter_recovery_done(). Returning from reload_up does >not guarantee successful activation of firmware. Status of reset will >be notified to the health reporter via >devlink_health_reporter_state_update(). > >I am just repeating this, so I want to know if I am on the same page. > >Thanks. [...]