From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A70DC43461 for ; Mon, 14 Sep 2020 13:48:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11402208E4 for ; Mon, 14 Sep 2020 13:48:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="kh+CVeN9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbgINNsy (ORCPT ); Mon, 14 Sep 2020 09:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbgINNpF (ORCPT ); Mon, 14 Sep 2020 09:45:05 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE28C06178B for ; Mon, 14 Sep 2020 06:45:03 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id a12so17623556eds.13 for ; Mon, 14 Sep 2020 06:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P4Vr4Y7phYqh0vokWotddxjtKZaBZJodByw1Suscz0A=; b=kh+CVeN9meb1AoxLYMWvaTFPYGifkZuTlSS1+0GGui9jRMcQ532JZE0NIDZ+QpEFVp GUfPCEYOcaR95os+/TZk9gwopzKlrzvNngyBuRLeEsHpDjkS2GvWaHPj1PL5VQ6LwdpD 2cHlkMfsQjw13Fj3KX+BGoEYAcNwWMueEx+qaBzlIy73doysx5bYqC1XOqy+k4B2wDqz XwXPjefF/aVv1IoSlJAzXoXV4FJvWgxKTqvnUH3HOWmH1UgHFDdLXOiRBEkmmAvA2J2q idk5DDmM89MdT0BAO8NAhpDGeP09C2TOquNfZrZMBFN6KpEmS+u7wz9ZEuIkDONFHzkG 2mMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P4Vr4Y7phYqh0vokWotddxjtKZaBZJodByw1Suscz0A=; b=P6/0JL0Rh9vkxxXMSb7OqXlSrB2LcvWCuQFg/zhX+D/FW/fydZkIG0Btsv3jiqeb4Y 9E/GsP5I4odOflwfGu72OXvuFy5MXh2l3nMRcZIKluMmnTvGlFEohsFWnA3CppLj3+PG siwrD8sSiQyOmr/ocisRARb8IY8EXgD3xWj2Xf/bt6blA7Z4fOdxF4WU/zvNAFMhrvPU cpXbKYn33kyXRDuUMW/x/2gyhtKdtwIMKvOfGcdsVOdY6z5qRsVrqYKAVLZZ6BDJgIfL Iq4fGz0D3teSiwT+b4uHV0wLAt8Bk3/K8IOOsbpPeiRGkKpPdKWu10/Ex1ZdXzRItlIy sJVw== X-Gm-Message-State: AOAM532TsA2UDrsRlhg0pc1TPHEY3OC0snDxC00F2bfkvkjC8XCZ4rpF qQYucO8u59NEbj0i59gNsZ/Fag== X-Google-Smtp-Source: ABdhPJwrz78ykRk6o2gKTF3aKAzlbbpoL1QIxo40v3Yo2G4fRlFwh/nH8OxStDeU0gzs5eu9YxiRag== X-Received: by 2002:aa7:dac5:: with SMTP id x5mr12982822eds.72.1600091101751; Mon, 14 Sep 2020 06:45:01 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id a18sm7745507ejy.71.2020.09.14.06.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 06:45:01 -0700 (PDT) Date: Mon, 14 Sep 2020 15:45:00 +0200 From: Jiri Pirko To: Moshe Shemesh Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, idosch@idosch.org Subject: Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get Message-ID: <20200914134500.GH2236@nanopsycho.orion> References: <1600063682-17313-1-git-send-email-moshe@mellanox.com> <1600063682-17313-5-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600063682-17313-5-git-send-email-moshe@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Sep 14, 2020 at 08:07:51AM CEST, moshe@mellanox.com wrote: >Expose devlink reload actions stats to the user through devlink dev >get command. > >Examples: >$ devlink dev show >pci/0000:82:00.0: > reload_action_stats: > driver_reinit 2 > fw_activate 1 > driver_reinit_no_reset 0 > fw_activate_no_reset 0 >pci/0000:82:00.1: > reload_action_stats: > driver_reinit 1 > fw_activate 1 > driver_reinit_no_reset 0 > fw_activate_no_reset 0 I would rather have something like: stats: reload_action: driver_reinit 1 fw_activate 1 driver_reinit_no_reset 0 fw_activate_no_reset 0 Then we can easily extend and add other stats in the tree. Also, I wonder if these stats could be somehow merged with Ido's metrics work: https://github.com/idosch/linux/commits/submit/devlink_metric_rfc_v1 Ido, would it make sense? > >$ devlink dev show -jp >{ > "dev": { > "pci/0000:82:00.0": { > "reload_action_stats": [ { > "driver_reinit": 2 > },{ > "fw_activate": 1 > },{ > "driver_reinit_no_reset": 0 > },{ > "fw_activate_no_reset": 0 > } ] > }, > "pci/0000:82:00.1": { > "reload_action_stats": [ { > "driver_reinit": 1 > },{ > "fw_activate": 1 > },{ > "driver_reinit_no_reset": 0 > },{ > "fw_activate_no_reset": 0 > } ] > } > } >} > [..]