From: Andrew Lunn <andrew@lunn.ch>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean
Date: Tue, 15 Sep 2020 16:03:26 +0200 [thread overview]
Message-ID: <20200915140326.GG3485708@lunn.ch> (raw)
In-Reply-To: <a28498acdf87f11e81d3282d63f18dbe1a3d5329.camel@kernel.org>
On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote:
> On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote:
> > After applying the patches below, the drivers/net/ethernet
> > directory can be built as modules with W=1 with no warnings (so
> > far on x64_64 arch only!).
> > As Jakub pointed out, there is much more work to do to clean up
> > C=1, but that will be another series of changes.
> >
> > This series removes 1,283 warnings and hopefully allows the
> > ethernet directory to move forward from here without more
> > warnings being added. There is only one objtool warning now.
> >
> > Some of these patches are already sent to Intel Wired Lan, but
> > the rest of the series titled drivers/net/ethernet affects other
> > drivers. The changes are all pretty straightforward.
> >
> > As part of testing this series I realized that I have ~1,500 more
> > kdoc warnings to fix due to being in other arch or not compiled
> > with my x86_64 .config. Feel free to run
> > $ 'git ls-files *.[ch] | grep drivers/net/ethernet | xargs
> > scripts/kernel-doc -none'
> > to see the remaining issues.
> >
>
> Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
>
> Hi Jesse,
> What was the criteria to select which drivers to enable in your .config
> ?
>
> I think we need some automation here and have a well known .config that
> enables as many drivers as we can for static + compilation testing,
> otherwise we are going to need to repeat this patch every 2-3 months.
Hi Saeed
I would prefer we just enable W=1 by default for everything under
driver/net. Maybe there is something we can set in
driver/net/Makefile?
Andrew
next prev parent reply other threads:[~2020-09-15 14:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 1:44 [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 01/10] i40e: prepare flash string in a simpler way Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 02/10] intel-ethernet: clean up W=1 warnings in kdoc Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 03/10] intel: handle unused assignments Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 04/10] drivers/net/ethernet: clean up " Jesse Brandeburg
2020-09-15 9:02 ` Edward Cree
2020-09-15 1:44 ` [PATCH net-next v2 05/10] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 06/10] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg
2020-09-15 3:25 ` Saeed Mahameed
2020-09-15 16:41 ` Jesse Brandeburg
2020-09-17 20:06 ` Rustad, Mark D
2020-09-15 1:44 ` [PATCH net-next v2 07/10] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 08/10] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg
2020-09-15 1:44 ` [PATCH net-next v2 09/10] sfc: fix kdoc warning Jesse Brandeburg
2020-09-15 9:05 ` Edward Cree
2020-09-15 1:44 ` [PATCH net-next v2 10/10] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg
2020-09-15 4:24 ` [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean Saeed Mahameed
2020-09-15 14:03 ` Andrew Lunn [this message]
2020-09-15 20:03 ` Saeed Mahameed
2020-09-15 20:43 ` Andrew Lunn
2020-09-15 22:37 ` David Miller
2020-09-15 15:58 ` Jakub Kicinski
2020-09-15 17:11 ` Jesse Brandeburg
2020-09-15 20:31 ` David Miller
2020-09-15 21:00 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915140326.GG3485708@lunn.ch \
--to=andrew@lunn.ch \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).