From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7821CC43461 for ; Tue, 15 Sep 2020 14:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8AA206C9 for ; Tue, 15 Sep 2020 14:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727249AbgIOOoE (ORCPT ); Tue, 15 Sep 2020 10:44:04 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36342 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgIOOnR (ORCPT ); Tue, 15 Sep 2020 10:43:17 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kIBYM-00Em7H-BY; Tue, 15 Sep 2020 16:03:26 +0200 Date: Tue, 15 Sep 2020 16:03:26 +0200 From: Andrew Lunn To: Saeed Mahameed Cc: Jesse Brandeburg , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean Message-ID: <20200915140326.GG3485708@lunn.ch> References: <20200915014455.1232507-1-jesse.brandeburg@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote: > On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > > After applying the patches below, the drivers/net/ethernet > > directory can be built as modules with W=1 with no warnings (so > > far on x64_64 arch only!). > > As Jakub pointed out, there is much more work to do to clean up > > C=1, but that will be another series of changes. > > > > This series removes 1,283 warnings and hopefully allows the > > ethernet directory to move forward from here without more > > warnings being added. There is only one objtool warning now. > > > > Some of these patches are already sent to Intel Wired Lan, but > > the rest of the series titled drivers/net/ethernet affects other > > drivers. The changes are all pretty straightforward. > > > > As part of testing this series I realized that I have ~1,500 more > > kdoc warnings to fix due to being in other arch or not compiled > > with my x86_64 .config. Feel free to run > > $ 'git ls-files *.[ch] | grep drivers/net/ethernet | xargs > > scripts/kernel-doc -none' > > to see the remaining issues. > > > > Reviewed-by: Saeed Mahameed > > Hi Jesse, > What was the criteria to select which drivers to enable in your .config > ? > > I think we need some automation here and have a well known .config that > enables as many drivers as we can for static + compilation testing, > otherwise we are going to need to repeat this patch every 2-3 months. Hi Saeed I would prefer we just enable W=1 by default for everything under driver/net. Maybe there is something we can set in driver/net/Makefile? Andrew