From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AECC433E2 for ; Tue, 15 Sep 2020 20:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92C9A206BE for ; Tue, 15 Sep 2020 20:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727730AbgIOUKw (ORCPT ); Tue, 15 Sep 2020 16:10:52 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37024 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727847AbgIOUKZ (ORCPT ); Tue, 15 Sep 2020 16:10:25 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kIHHK-00EoXa-3p; Tue, 15 Sep 2020 22:10:14 +0200 Date: Tue, 15 Sep 2020 22:10:14 +0200 From: Andrew Lunn To: Dan Murphy Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, mkubecek@suse.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries Message-ID: <20200915201014.GC3526428@lunn.ch> References: <20200915181708.25842-1-dmurphy@ti.com> <20200915181708.25842-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915181708.25842-2-dmurphy@ti.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: > @@ -160,6 +160,8 @@ static const struct phy_setting settings[] = { > PHY_SETTING( 100, FULL, 100baseT_Full ), > PHY_SETTING( 100, FULL, 100baseT1_Full ), > PHY_SETTING( 100, HALF, 100baseT_Half ), > + PHY_SETTING( 100, HALF, 100baseFX_Half ), > + PHY_SETTING( 100, FULL, 100baseFX_Full ), Hi Dan Does 100baseFX_Half make an sense? My understanding of 802.3 section 26 is that it is always a pair, not a single fibre where you might need CSMA/CD? Andrew