From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A698C433E2 for ; Tue, 15 Sep 2020 21:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6818B20731 for ; Tue, 15 Sep 2020 21:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbgIOVio (ORCPT ); Tue, 15 Sep 2020 17:38:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37286 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728109AbgIOVhz (ORCPT ); Tue, 15 Sep 2020 17:37:55 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kIIdr-00EpFF-Qz; Tue, 15 Sep 2020 23:37:35 +0200 Date: Tue, 15 Sep 2020 23:37:35 +0200 From: Andrew Lunn To: Oded Gabbay Cc: Jakub Kicinski , "Linux-Kernel@Vger. Kernel. Org" , netdev@vger.kernel.org, SW_Drivers , Greg Kroah-Hartman , "David S. Miller" , Florian Fainelli , linux-rdma@vger.kernel.org Subject: Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver Message-ID: <20200915213735.GG3526428@lunn.ch> References: <20200915171022.10561-1-oded.gabbay@gmail.com> <20200915133556.21268811@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200915140418.4afbc1eb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I completely understand but you didn't answer my question. How come > there are drivers which create netdev objects, and specifically sgi-xp > in misc (but I also saw it in usb drivers) that live outside > drivers/net ? Why doesn't your request apply to them as well ? > When we wrote the code, we saw those examples and therefore assumed it was fine. commit 45d9ca492e4bd1522d1b5bd125c2908f1cee3d4a Author: Dean Nelson Date: Tue Apr 22 14:46:56 2008 -0500 [IA64] move XP and XPC to drivers/misc/sgi-xp Move XPC and XPNET from arch/ia64/sn/kernel to drivers/misc/sgi-xp. Signed-off-by: Dean Nelson Signed-off-by: Tony Luck It has been there a long time, and no networking person was involved in its move. drivers/usb/gadget/function/f_ncm.c commit 00a2430ff07d4e0e0e7e24e02fd8adede333b797 Author: Andrzej Pietrasiewicz Date: Tue Jul 15 13:09:46 2014 +0200 usb: gadget: Gadget directory cleanup - group usb functions The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the USB functions implementations into a separate directory. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Felipe Balbi Again, old. Can you find an example of a network driver added in the last couple of years outside of drivers/met? > > > > Please make sure to CC linux-rdma. You clearly stated that the device > > > > does RDMA-like transfers. > > > > > > We don't use the RDMA infrastructure in the kernel and we can't > > > connect to it due to the lack of H/W support we have so I don't see > > > why we need to CC linux-rdma. > > > > You have it backward. You don't get to pick and choose which parts of > > the infrastructure you use, and therefore who reviews your drivers. > > The device uses RDMA under the hood so Linux RDMA experts must very > > much be okay with it getting merged. That's how we ensure Linux > > interfaces are consistent and good quality. > > I understand your point of view but If my H/W doesn't support the > basic requirements of the RDMA infrastructure and interfaces, then > really there is nothing I can do about it. I can't use them. It is up to the RDMA people to say that. They might see how the RDMA core can be made to work for your hardware. Andrew