From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A4CC43461 for ; Wed, 16 Sep 2020 19:12:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4541C20708 for ; Wed, 16 Sep 2020 19:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600283536; bh=9s/rvEjo1wq+KwkqjNhV00XmoufWCEUO/ivOHV5rAGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=drDDaifmUaJG6+p55f+Eqm/R76J8lDUvUXzptQneSErqkIh1UNdVrwa7+gmoza+8H 5qd60dVs7j62XNoroFBmWYPpMk5sY1rWtlXkGVpuK3WFIPbYQNuLAhzZcBchY5/Oap FKs5+ZyLH8crzv0+TrOeWymRhCs1wuwhaMpTCmW4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbgIPTMK (ORCPT ); Wed, 16 Sep 2020 15:12:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:56304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727324AbgIPRkk (ORCPT ); Wed, 16 Sep 2020 13:40:40 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00CB822208; Wed, 16 Sep 2020 12:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600257620; bh=9s/rvEjo1wq+KwkqjNhV00XmoufWCEUO/ivOHV5rAGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MztvbYDnbk2NXEcYstZNeAJ6aWgFbPSOOSfLrbFaXyxEfjR7wHm1e1+gUiW8w061N RV0g8a+uEO39D8pZCvr+axOuo72XFHhRWiTJv8tlpilNbrnF0hICqbc4wGKmBdhUpF br/L1V9FN/vYx1Os7u42M45FthQreInRFat5d+qQ= Date: Wed, 16 Sep 2020 14:00:54 +0200 From: Greg Kroah-Hartman To: Oded Gabbay Cc: David Miller , "Linux-Kernel@Vger. Kernel. Org" , netdev@vger.kernel.org, SW_Drivers , Jakub Kicinski , Andrew Lunn , Florian Fainelli Subject: Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver Message-ID: <20200916120054.GA2753544@kroah.com> References: <20200915171022.10561-1-oded.gabbay@gmail.com> <20200915.134252.1280841239760138359.davem@davemloft.net> <20200916062614.GF142621@kroah.com> <20200916074217.GB189144@kroah.com> <20200916082226.GA509119@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 16, 2020 at 11:47:58AM +0300, Oded Gabbay wrote: > On Wed, Sep 16, 2020 at 11:21 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > > > On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > > > > > On Wed, Sep 16, 2020 at 9:25 AM Greg Kroah-Hartman > > > > > wrote: > > > > > > > > > > > > On Tue, Sep 15, 2020 at 11:49:12PM +0300, Oded Gabbay wrote: > > > > > > > On Tue, Sep 15, 2020 at 11:42 PM David Miller wrote: > > > > > > > > > > > > > > > > From: Oded Gabbay > > > > > > > > Date: Tue, 15 Sep 2020 20:10:08 +0300 > > > > > > > > > > > > > > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > > > > > > > > into the habanalabs driver. > > > > > > > > > > > > > > > > > > The only modification from v2 is in the ethtool patch (patch 12). Details > > > > > > > > > are in that patch's commit message. > > > > > > > > > > > > > > > > > > Link to v2 cover letter: > > > > > > > > > https://lkml.org/lkml/2020/9/12/201 > > > > > > > > > > > > > > > > I agree with Jakub, this driver definitely can't go-in as it is currently > > > > > > > > structured and designed. > > > > > > > Why is that ? > > > > > > > Can you please point to the things that bother you or not working correctly? > > > > > > > I can't really fix the driver if I don't know what's wrong. > > > > > > > > > > > > > > In addition, please read my reply to Jakub with the explanation of why > > > > > > > we designed this driver as is. > > > > > > > > > > > > > > And because of the RDMA'ness of it, the RDMA > > > > > > > > folks have to be CC:'d and have a chance to review this. > > > > > > > As I said to Jakub, the driver doesn't use the RDMA infrastructure in > > > > > > > the kernel and we can't connect to it due to the lack of H/W support > > > > > > > we have > > > > > > > Therefore, I don't see why we need to CC linux-rdma. > > > > > > > I understood why Greg asked me to CC you because we do connect to the > > > > > > > netdev and standard eth infrastructure, but regarding the RDMA, it's > > > > > > > not really the same. > > > > > > > > > > > > Ok, to do this "right" it needs to be split up into separate drivers, > > > > > > hopefully using the "virtual bus" code that some day Intel will resubmit > > > > > > again that will solve this issue. > > > > > Hi Greg, > > > > > Can I suggest an alternative for the short/medium term ? > > > > > > > > > > In an earlier email, Jakub said: > > > > > "Is it not possible to move the files and still build them into a single > > > > > module?" > > > > > > > > > > I thought maybe that's a good way to progress here ? > > > > > > > > Cross-directory builds of a single module are crazy. Yes, they work, > > > > but really, that's a mess, and would never suggest doing that. > > > > > > > > > First, split the content to Ethernet and RDMA. > > > > > Then move the Ethernet part to drivers/net but build it as part of > > > > > habanalabs.ko. > > > > > Regarding the RDMA code, upstream/review it in a different patch-set > > > > > (maybe they will want me to put the files elsewhere). > > > > > > > > > > What do you think ? > > > > > > > > I think you are asking for more work there than just splitting out into > > > > separate modules :) > > > > > > > > thanks, > > > > > > > > greg k-h > > > Hi Greg, > > > > > > If cross-directory building is out of the question, what about > > > splitting into separate modules ? And use cross-module notifiers/calls > > > ? I did that with amdkfd and amdgpu/radeon a couple of years back. It > > > worked (that's the best thing I can say about it). > > > > That's fine with me. > > > > > The main problem with this "virtual bus" thing is that I'm not > > > familiar with it at all and from my experience I imagine it would take > > > a considerable time and effort to upstream this infrastructure work. > > > > It shouldn't be taking that long, but for some unknown reason, the > > original author of that code is sitting on it and not resending it. Go > > poke them through internal Intel channels to find out what the problem > > is, as I have no clue why a 200-300 line bus module is taking so long to > > get "right" :( > > > > I'm _ALMOST_ at the point where I would just do that work myself, but > > due to my current status with Intel, I'll let them do it as I have > > enough other things on my plate... > > > > > This could delay the NIC code for a couple of years, which by then > > > this won't be relevant at all. > > > > Why wouldn't this code be relevant in a year? It's going to be 2+ years > > before any of this shows up in an "enterprise distro" based on their > > release cycles anyway :) > > > > thanks, > > > > greg k-h > > Hi Greg, > ok, I'll take a look. Do you happen to have the name of the patch-set / author ? Here's at least one copy: https://lore.kernel.org/linux-rdma/20200520070227.3392100-2-jeffrey.t.kirsher@intel.com/ there might have been a newer one, can't remember, sorry. thanks, greg k-h