* [PATCH net] nfp: use correct define to return NONE fec
@ 2020-09-17 17:52 Jakub Kicinski
2020-09-17 18:11 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-09-17 17:52 UTC (permalink / raw)
To: davem; +Cc: netdev, simon.horman, oss-drivers, Jakub Kicinski
struct ethtool_fecparam carries bitmasks not bit numbers.
We want to return 1 (NONE), not 0.
Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
index 6eb9fb9a1814..9c9ae33d84ce 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
@@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,
struct nfp_eth_table_port *eth_port;
struct nfp_port *port;
- param->active_fec = ETHTOOL_FEC_NONE_BIT;
- param->fec = ETHTOOL_FEC_NONE_BIT;
+ param->active_fec = ETHTOOL_FEC_NONE;
+ param->fec = ETHTOOL_FEC_NONE;
port = nfp_port_from_netdev(netdev);
eth_port = nfp_port_get_eth_port(port);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] nfp: use correct define to return NONE fec
2020-09-17 17:52 [PATCH net] nfp: use correct define to return NONE fec Jakub Kicinski
@ 2020-09-17 18:11 ` Simon Horman
2020-09-17 18:26 ` Jesse Brandeburg
2020-09-18 0:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2020-09-17 18:11 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, oss-drivers
On Thu, Sep 17, 2020 at 10:52:57AM -0700, Jakub Kicinski wrote:
> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
>
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index 6eb9fb9a1814..9c9ae33d84ce 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,
> struct nfp_eth_table_port *eth_port;
> struct nfp_port *port;
>
> - param->active_fec = ETHTOOL_FEC_NONE_BIT;
> - param->fec = ETHTOOL_FEC_NONE_BIT;
> + param->active_fec = ETHTOOL_FEC_NONE;
> + param->fec = ETHTOOL_FEC_NONE;
>
> port = nfp_port_from_netdev(netdev);
> eth_port = nfp_port_get_eth_port(port);
Reviewed-by: Simon Horman <simon.horman@netronome.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] nfp: use correct define to return NONE fec
2020-09-17 17:52 [PATCH net] nfp: use correct define to return NONE fec Jakub Kicinski
2020-09-17 18:11 ` Simon Horman
@ 2020-09-17 18:26 ` Jesse Brandeburg
2020-09-18 0:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jesse Brandeburg @ 2020-09-17 18:26 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, simon.horman, oss-drivers
Jakub Kicinski wrote:
> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
>
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Good catch!
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] nfp: use correct define to return NONE fec
2020-09-17 17:52 [PATCH net] nfp: use correct define to return NONE fec Jakub Kicinski
2020-09-17 18:11 ` Simon Horman
2020-09-17 18:26 ` Jesse Brandeburg
@ 2020-09-18 0:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-18 0:59 UTC (permalink / raw)
To: kuba; +Cc: netdev, simon.horman, oss-drivers
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 17 Sep 2020 10:52:57 -0700
> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
>
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-18 0:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-17 17:52 [PATCH net] nfp: use correct define to return NONE fec Jakub Kicinski
2020-09-17 18:11 ` Simon Horman
2020-09-17 18:26 ` Jesse Brandeburg
2020-09-18 0:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).