From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C28C43461 for ; Thu, 17 Sep 2020 18:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82174221F1 for ; Thu, 17 Sep 2020 18:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbgIQS1m (ORCPT ); Thu, 17 Sep 2020 14:27:42 -0400 Received: from mga02.intel.com ([134.134.136.20]:34824 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgIQS1I (ORCPT ); Thu, 17 Sep 2020 14:27:08 -0400 IronPort-SDR: Vh06kQPfuzX5bqEMrZm6xtTJqzLOqbTysiIJqPvB5eZCUj7bpQupAgAsNoxFic+5ccpeqM6N/J Xpal861q8dTA== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="147453694" X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="147453694" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 11:26:39 -0700 IronPort-SDR: zvIu7r0T3J1bEagPKIhVq8sbXV/5IEdJN9wQZ/7o7EDmRRMos2/KKIrb04snyTX6FDJX5Pvi4N Ea0VeZ0s0cKw== X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="483853045" Received: from jbrandeb-mobl3.amr.corp.intel.com (HELO localhost) ([10.251.16.238]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 11:26:38 -0700 Date: Thu, 17 Sep 2020 11:26:38 -0700 From: Jesse Brandeburg To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, simon.horman@netronome.com, oss-drivers@netronome.com Subject: Re: [PATCH net] nfp: use correct define to return NONE fec Message-ID: <20200917112638.00007d5c@intel.com> In-Reply-To: <20200917175257.592636-1-kuba@kernel.org> References: <20200917175257.592636-1-kuba@kernel.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski wrote: > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski Good catch! Reviewed-by: Jesse Brandeburg