From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900CEC43461 for ; Thu, 17 Sep 2020 17:54:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32779206C3 for ; Thu, 17 Sep 2020 17:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600365255; bh=6r/fiVpBEb2E6ivgukANgR/YTf3KbB5pwT1Vur5JxnQ=; h=From:To:Cc:Subject:Date:List-ID:From; b=t4xZRBdw+bYimmiTxXErS+H78skWn2ujGrtJhqe7jlaIA/4uZ5L0jSqU4XKs/Mqy1 2l+EYuQfkyjlwGFPdJU7OESsz1OEqoocX7SxORnwiFLXmQ2GqmPvwk9k5/dvCTYtXz oP9dHo+74JuNOS12n93pjokqmBDCNVIzkT/yMB7o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbgIQRxt (ORCPT ); Thu, 17 Sep 2020 13:53:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:45866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbgIQRxI (ORCPT ); Thu, 17 Sep 2020 13:53:08 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2EFE206C3; Thu, 17 Sep 2020 17:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600365188; bh=6r/fiVpBEb2E6ivgukANgR/YTf3KbB5pwT1Vur5JxnQ=; h=From:To:Cc:Subject:Date:From; b=zseFi8ZicmmOjXcRwLP18pJs7XMR0XkQMZHKjYsVERwuqs2IhSWkbqcY6UdlPqmjR ahUZVlSyljaSVV7NQiBbx0f1llE0C3bVE56eOkdcqGFL/zDO61aR19SXosyaHGtyPO joo93mQyQCL6oOxv5PpBcjWpz/aQibLBRWNoUKCg= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, simon.horman@netronome.com, oss-drivers@netronome.com, Jakub Kicinski Subject: [PATCH net] nfp: use correct define to return NONE fec Date: Thu, 17 Sep 2020 10:52:57 -0700 Message-Id: <20200917175257.592636-1-kuba@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0. Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c index 6eb9fb9a1814..9c9ae33d84ce 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c @@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev, struct nfp_eth_table_port *eth_port; struct nfp_port *port; - param->active_fec = ETHTOOL_FEC_NONE_BIT; - param->fec = ETHTOOL_FEC_NONE_BIT; + param->active_fec = ETHTOOL_FEC_NONE; + param->fec = ETHTOOL_FEC_NONE; port = nfp_port_from_netdev(netdev); eth_port = nfp_port_get_eth_port(port); -- 2.26.2