From: Simon Horman <simon.horman@netronome.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net] nfp: use correct define to return NONE fec
Date: Thu, 17 Sep 2020 20:11:00 +0200 [thread overview]
Message-ID: <20200917181059.GA13324@netronome.com> (raw)
In-Reply-To: <20200917175257.592636-1-kuba@kernel.org>
On Thu, Sep 17, 2020 at 10:52:57AM -0700, Jakub Kicinski wrote:
> struct ethtool_fecparam carries bitmasks not bit numbers.
> We want to return 1 (NONE), not 0.
>
> Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index 6eb9fb9a1814..9c9ae33d84ce 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,
> struct nfp_eth_table_port *eth_port;
> struct nfp_port *port;
>
> - param->active_fec = ETHTOOL_FEC_NONE_BIT;
> - param->fec = ETHTOOL_FEC_NONE_BIT;
> + param->active_fec = ETHTOOL_FEC_NONE;
> + param->fec = ETHTOOL_FEC_NONE;
>
> port = nfp_port_from_netdev(netdev);
> eth_port = nfp_port_get_eth_port(port);
Reviewed-by: Simon Horman <simon.horman@netronome.com>
next prev parent reply other threads:[~2020-09-17 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:52 [PATCH net] nfp: use correct define to return NONE fec Jakub Kicinski
2020-09-17 18:11 ` Simon Horman [this message]
2020-09-17 18:26 ` Jesse Brandeburg
2020-09-18 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917181059.GA13324@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).