From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04289C43464 for ; Thu, 17 Sep 2020 21:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBA6B21D92 for ; Thu, 17 Sep 2020 21:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbgIQVms (ORCPT ); Thu, 17 Sep 2020 17:42:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41558 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQVmr (ORCPT ); Thu, 17 Sep 2020 17:42:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kJ1ft-00F8jM-Uo; Thu, 17 Sep 2020 23:42:41 +0200 Date: Thu, 17 Sep 2020 23:42:41 +0200 From: Andrew Lunn To: Michal Kubecek Cc: David Miller , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ethtool: add and use message type for tunnel info reply Message-ID: <20200917214241.GC3598897@lunn.ch> References: <20200916230410.34FCE6074F@lion.mk-sys.cz> <20200917014151.GK3463198@lunn.ch> <20200917212919.3n6f3zdegjeyhfud@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917212919.3n6f3zdegjeyhfud@lion.mk-sys.cz> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On the other hand, the enums are part of userspace API so I better take > a closer look to make sure we don't run into some trouble there. Hi Michal Yes, that is what i was thinking about. But i guess you can pass a tagged enum to a function expecting an int and the compiler will silently cast it. Which is what we should have at the moment. So i'm expecting it to be O.K. Andrew