From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DCDC43463 for ; Fri, 18 Sep 2020 02:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26607208E4 for ; Fri, 18 Sep 2020 02:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395120; bh=x8otqe658uFEM+ovxAz7zRbLHXxEy6UTkVWx/+qbFLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dEgDVqXPRKu7X5Agk/QLZKyjpw1X+/1UQ0fycLCE6D5WLuW8WCS/qui0PrAjtINeY ApZtj4mUo2IgkwgCG/RpkyqkCY9OPbwzflQ2MO7YknAhm7gv2xFJXLUXDcGWEFMi86 tPjdLwLTxQ3A6LbbSUx/YrUfORitjq7pJGDJ8JJg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbgIRCL7 (ORCPT ); Thu, 17 Sep 2020 22:11:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:37862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728174AbgIRCLy (ORCPT ); Thu, 17 Sep 2020 22:11:54 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3035F235F7; Fri, 18 Sep 2020 02:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395114; bh=x8otqe658uFEM+ovxAz7zRbLHXxEy6UTkVWx/+qbFLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z9dMj9qMvX9IiXdxpT3uiVeUqyH4A93SCiTH1k0/N7+GMXGpM2/8Y4xBBCsCvbH/x ZNG0RD9aLPlFJReUf2cTHc6mOEpvTbCdIA+PC9QELFYGszd82C9xdGURHQrFSEMwOR kPUJCBwYmWbn05xFDn2iaOzBT4DsEhSX6gDnpotA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dinghao Liu , Tony Lindgren , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 187/206] wlcore: fix runtime pm imbalance in wlcore_regdomain_config Date: Thu, 17 Sep 2020 22:07:43 -0400 Message-Id: <20200918020802.2065198-187-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918020802.2065198-1-sashal@kernel.org> References: <20200918020802.2065198-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dinghao Liu [ Upstream commit 282a04bf1d8029eb98585cb5db3fd70fe8bc91f7 ] pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu Acked-by: Tony Lindgren Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200520124649.10848-1-dinghao.liu@zju.edu.cn Signed-off-by: Sasha Levin --- drivers/net/wireless/ti/wlcore/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 2ca5658bbc2ab..43c7b37dec0c9 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -3671,8 +3671,10 @@ void wlcore_regdomain_config(struct wl1271 *wl) goto out; ret = pm_runtime_get_sync(wl->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_autosuspend(wl->dev); goto out; + } ret = wlcore_cmd_regdomain_config_locked(wl); if (ret < 0) { -- 2.25.1