From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Achiad Shochat <achiad@mellanox.com>,
Adit Ranadive <aditr@vmware.com>,
Aharon Landau <aharonl@mellanox.com>,
"Ariel Elior" <aelior@marvell.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>, <linux-rdma@vger.kernel.org>,
"Michael Guralnik" <michaelgur@nvidia.com>,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
<netdev@vger.kernel.org>, Saeed Mahameed <saeedm@nvidia.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
VMware PV-Drivers <pv-drivers@vmware.com>
Subject: Re: [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type
Date: Fri, 18 Sep 2020 10:33:49 -0300 [thread overview]
Message-ID: <20200918133349.GB3699@nvidia.com> (raw)
In-Reply-To: <20200917230442.GZ3699@nvidia.com>
On Thu, Sep 17, 2020 at 08:04:42PM -0300, Jason Gunthorpe wrote:
> On Thu, Sep 17, 2020 at 07:35:20PM +0300, Leon Romanovsky wrote:
> > On Thu, Sep 17, 2020 at 08:41:54AM -0300, Jason Gunthorpe wrote:
> > > On Thu, Sep 17, 2020 at 12:02:20PM +0300, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@nvidia.com>
> > > >
> > > > Changelog:
> > > > v2:
> > > > * Changed WARN_ON casting to be saturated value instead while returning active_speed
> > > > to the user.
> > > > v1: https://lore.kernel.org/linux-rdma/20200902074503.743310-1-leon@kernel.org
> > > > * Changed patch #1 to fix memory corruption to help with bisect. No
> > > > change in series, because the added code is changed anyway in patch
> > > > #3.
> > > > v0:
> > > > * https://lore.kernel.org/linux-rdma/20200824105826.1093613-1-leon@kernel.org
> > > >
> > > >
> > > > IBTA declares speed as 16 bits, but kernel stores it in u8. This series
> > > > fixes in-kernel declaration while keeping external interface intact.
> > > >
> > > > Thanks
> > > >
> > > > Aharon Landau (3):
> > > > net/mlx5: Refactor query port speed functions
> > > > RDMA/mlx5: Delete duplicated mlx5_ptys_width enum
> > > > RDMA: Fix link active_speed size
> > >
> > > Look OK, can you update the shared branch?
> >
> > I pushed first two patches to mlx5-next branch:
> >
> > e27014bdb47e RDMA/mlx5: Delete duplicated mlx5_ptys_width enum
> > 639bf4415cad net/mlx5: Refactor query port speed functions
>
> Applied to for-next, thanks
Actually it needed a little help with this:
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index caa9c5966e44bd..a7e203bcb012db 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -535,7 +535,8 @@ enum ib_port_speed {
IB_SPEED_FDR10 = 8,
IB_SPEED_FDR = 16,
IB_SPEED_EDR = 32,
- IB_SPEED_HDR = 64
+ IB_SPEED_HDR = 64,
+ IB_SPEED_NDR = 128,
};
/**
I fixed it
Jason
prev parent reply other threads:[~2020-09-18 13:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 9:02 [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type Leon Romanovsky
2020-09-17 9:02 ` [PATCH mlx5-next v2 1/3] net/mlx5: Refactor query port speed functions Leon Romanovsky
2020-09-17 9:02 ` [PATCH mlx5-next v2 2/3] RDMA/mlx5: Delete duplicated mlx5_ptys_width enum Leon Romanovsky
2020-09-17 11:41 ` [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type Jason Gunthorpe
2020-09-17 16:35 ` Leon Romanovsky
2020-09-17 23:04 ` Jason Gunthorpe
2020-09-18 13:33 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918133349.GB3699@nvidia.com \
--to=jgg@nvidia.com \
--cc=achiad@mellanox.com \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=aharonl@mellanox.com \
--cc=dennis.dalessandro@intel.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=mike.marciniszyn@intel.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=saeedm@nvidia.com \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).