From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC08C43464 for ; Fri, 18 Sep 2020 15:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BF87238D6 for ; Fri, 18 Sep 2020 15:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbgIRP26 (ORCPT ); Fri, 18 Sep 2020 11:28:58 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60005 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726306AbgIRP24 (ORCPT ); Fri, 18 Sep 2020 11:28:56 -0400 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 63397FF809; Fri, 18 Sep 2020 15:28:54 +0000 (UTC) Date: Fri, 18 Sep 2020 17:28:54 +0200 From: Alexandre Belloni To: Vladimir Oltean Cc: davem@davemloft.net, netdev@vger.kernel.org, yangbo.lu@nxp.com, xiaoliang.yang_1@nxp.com, UNGLinuxDriver@microchip.com, claudiu.manoil@nxp.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org Subject: Re: [PATCH v2 net 7/8] net: mscc: ocelot: unregister net devices on unbind Message-ID: <20200918152854.GD9675@piout.net> References: <20200918010730.2911234-1-olteanv@gmail.com> <20200918010730.2911234-8-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918010730.2911234-8-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/09/2020 04:07:29+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > This driver was not unregistering its network interfaces on unbind. > Now it is. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Horatiu Vultur Tested-by: Alexandre Belloni Reviewed-by: Alexandre Belloni > --- > Changes in v2: > No longer call mscc_ocelot_release_ports from the regular exit path of > mscc_ocelot_init_ports, which was incorrect. > > drivers/net/ethernet/mscc/ocelot_vsc7514.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c > index ff4a01424953..252c49b5f22b 100644 > --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c > +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c > @@ -896,6 +896,26 @@ static struct ptp_clock_info ocelot_ptp_clock_info = { > .enable = ocelot_ptp_enable, > }; > > +static void mscc_ocelot_release_ports(struct ocelot *ocelot) > +{ > + int port; > + > + for (port = 0; port < ocelot->num_phys_ports; port++) { > + struct ocelot_port_private *priv; > + struct ocelot_port *ocelot_port; > + > + ocelot_port = ocelot->ports[port]; > + if (!ocelot_port) > + continue; > + > + priv = container_of(ocelot_port, struct ocelot_port_private, > + port); > + > + unregister_netdev(priv->dev); > + free_netdev(priv->dev); > + } > +} > + > static int mscc_ocelot_init_ports(struct platform_device *pdev, > struct device_node *ports) > { > @@ -1132,6 +1152,7 @@ static int mscc_ocelot_remove(struct platform_device *pdev) > struct ocelot *ocelot = platform_get_drvdata(pdev); > > ocelot_deinit_timestamp(ocelot); > + mscc_ocelot_release_ports(ocelot); > ocelot_deinit(ocelot); > unregister_switchdev_blocking_notifier(&ocelot_switchdev_blocking_nb); > unregister_switchdev_notifier(&ocelot_switchdev_nb); > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com