From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, yangbo.lu@nxp.com,
xiaoliang.yang_1@nxp.com, UNGLinuxDriver@microchip.com,
claudiu.manoil@nxp.com, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, kuba@kernel.org
Subject: Re: [PATCH net-next 05/11] net: dsa: seville: remove unused defines for the mdio controller
Date: Fri, 18 Sep 2020 22:11:27 +0200 [thread overview]
Message-ID: <20200918201127.GA3616@piout.net> (raw)
In-Reply-To: <20200918185146.5322qugrmapyv7oo@skbuf>
On 18/09/2020 21:59:50+0300, Vladimir Oltean wrote:
> On Fri, Sep 18, 2020 at 07:37:19PM +0200, Alexandre Belloni wrote:
> > On 18/09/2020 18:54:42+0300, Vladimir Oltean wrote:
> > > On Fri, Sep 18, 2020 at 05:46:45PM +0200, Alexandre Belloni wrote:
> > > > On 18/09/2020 13:57:47+0300, Vladimir Oltean wrote:
> > > > > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> > > > >
> > > > > Some definitions were likely copied from
> > > > > drivers/net/mdio/mdio-mscc-miim.c.
> > > > >
> > > > > They are not necessary, remove them.
> > > >
> > > > Seeing that the mdio controller is probably the same, couldn't
> > > > mdio-mscc-miim be reused?
> > >
> > > Yeah, it probably can, but for 75 lines of code, is it worth it to
> > > butcher mdio-mscc-miim too? I'm not sure at what level that reuse should
> > > be. Should we pass it our regmap? mdio-mscc-miim doesn't use regmap.
> >
> > It may be worth it, I'm going to add DSA support for ocelot over SPI. So
> > to abstract the bus, it is probably worth moving to regmap.
>
> Wow, that's interesting, tell me more. For traffic, will you be using
> an NPI port, or some other configuration?
>
Yes, the plan is to use SPI for configuration and an NPI port for
traffic. The internal MIPS CPU will be disabled. If I'm not mistaken,
this is what is done for vsc73xx.
> And as for reusing mdio-mscc-miim, I think I'll look into that as a
> separate set of patches.
>
No worries, I can also take care of that. Or maybe you are right and it
doesn't make sense to do it.
next prev parent reply other threads:[~2020-09-18 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:57 [PATCH net-next 00/11] Felix DSA driver cleanup: build Seville separately Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 01/11] net: dsa: felix: use ocelot_field_{read,write} helpers consistently Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 02/11] net: dsa: seville: don't write to MEM_ENA twice Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 03/11] net: dsa: seville: first enable memories, then initialize them Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 04/11] net: dsa: ocelot: document why reset procedure is different for felix/seville Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 05/11] net: dsa: seville: remove unused defines for the mdio controller Vladimir Oltean
2020-09-18 15:46 ` Alexandre Belloni
2020-09-18 15:54 ` Vladimir Oltean
2020-09-18 17:37 ` Alexandre Belloni
2020-09-18 18:59 ` Vladimir Oltean
2020-09-18 20:11 ` Alexandre Belloni [this message]
2020-09-18 10:57 ` [PATCH net-next 06/11] net: dsa: seville: reindent defines for MDIO controller Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 07/11] net: dsa: felix: replace tabs with spaces Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 08/11] net: dsa: seville: duplicate vsc9959_mdio_bus_free Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 09/11] net: mscc: ocelot: make ocelot_init_timestamp take a const struct ptp_clock_info Vladimir Oltean
2020-09-18 15:31 ` Alexandre Belloni
2020-09-18 10:57 ` [PATCH net-next 10/11] net: dsa: felix: move the PTP clock structure to felix_vsc9959.c Vladimir Oltean
2020-09-18 10:57 ` [PATCH net-next 11/11] net: dsa: seville: build as separate module Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918201127.GA3616@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).