From: kernel test robot <lkp@intel.com>
To: Herrington <hankinsea@gmail.com>,
Richard Cochran <richardcochran@gmail.com>
Cc: kbuild-all@lists.01.org, leonro@nvidia.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hankinsea@gmail.com
Subject: Re: [PATCH v3] ptp: mark symbols static where possible
Date: Fri, 18 Sep 2020 23:21:13 +0800 [thread overview]
Message-ID: <202009182326.pg6nimUr%lkp@intel.com> (raw)
In-Reply-To: <20200918100943.1740-1-hankinsea@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4343 bytes --]
Hi Herrington,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc5 next-20200918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Herrington/ptp-mark-symbols-static-where-possible/20200918-181139
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 10b82d5176488acee2820e5a2cf0f2ec5c3488b6
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:12:
>> include/linux/ptp_clock_kernel.h:310:34: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
310 | void pch_ch_control_write(struct pci_dev *pdev, u32 val);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:311:30: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
311 | u32 pch_ch_event_read(struct pci_dev *pdev);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:312:32: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
312 | void pch_ch_event_write(struct pci_dev *pdev, u32 val);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:313:33: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
313 | u32 pch_src_uuid_lo_read(struct pci_dev *pdev);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:314:33: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
314 | u32 pch_src_uuid_hi_read(struct pci_dev *pdev);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:315:29: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
315 | u64 pch_rx_snap_read(struct pci_dev *pdev);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:316:29: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
316 | u64 pch_tx_snap_read(struct pci_dev *pdev);
| ^~~~~~~
include/linux/ptp_clock_kernel.h:317:46: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
317 | int pch_set_station_address(u8 *addr, struct pci_dev *pdev);
| ^~~~~~~
# https://github.com/0day-ci/linux/commit/d5fd7587ec0ce30118654a4b5c38a41a19ea5920
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Herrington/ptp-mark-symbols-static-where-possible/20200918-181139
git checkout d5fd7587ec0ce30118654a4b5c38a41a19ea5920
vim +310 include/linux/ptp_clock_kernel.h
309
> 310 void pch_ch_control_write(struct pci_dev *pdev, u32 val);
311 u32 pch_ch_event_read(struct pci_dev *pdev);
312 void pch_ch_event_write(struct pci_dev *pdev, u32 val);
313 u32 pch_src_uuid_lo_read(struct pci_dev *pdev);
314 u32 pch_src_uuid_hi_read(struct pci_dev *pdev);
315 u64 pch_rx_snap_read(struct pci_dev *pdev);
316 u64 pch_tx_snap_read(struct pci_dev *pdev);
317 int pch_set_station_address(u8 *addr, struct pci_dev *pdev);
318
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65335 bytes --]
prev parent reply other threads:[~2020-09-18 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:09 [PATCH v3] ptp: mark symbols static where possible Herrington
2020-09-18 14:34 ` Richard Cochran
2020-09-18 15:21 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009182326.pg6nimUr%lkp@intel.com \
--to=lkp@intel.com \
--cc=hankinsea@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).