* [PATCH -next 1/9] rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
@ 2020-09-18 10:24 ` Zheng Bin
2020-09-21 13:03 ` Kalle Valo
2020-09-18 10:24 ` [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c Zheng Bin
` (7 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:24 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c:797:6-33: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
index 473296e808ba..88fa2e593fef 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
@@ -794,7 +794,7 @@ static bool _rtl92ee_init_mac(struct ieee80211_hw *hw)
rtl_write_word(rtlpriv, REG_CR, 0x2ff);
if (!rtlhal->mac_func_enable) {
- if (_rtl92ee_llt_table_init(hw) == false) {
+ if (!_rtl92ee_llt_table_init(hw)) {
rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
"LLT table init fail\n");
return false;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
2020-09-18 10:24 ` [PATCH -next 1/9] rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c Zheng Bin
@ 2020-09-18 10:24 ` Zheng Bin
2020-09-18 20:47 ` Larry Finger
2020-09-18 10:24 ` [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c Zheng Bin
` (6 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:24 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
index fc6c81291cf5..6a3deca404b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
@@ -1103,7 +1103,7 @@ static void _rtl92c_phy_path_adda_on(struct ieee80211_hw *hw,
u32 i;
pathon = is_patha_on ? 0x04db25a4 : 0x0b1b25a4;
- if (false == is2t) {
+ if (!is2t) {
pathon = 0x0bdb25a0;
rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0b1b25a0);
} else {
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c
2020-09-18 10:24 ` [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c Zheng Bin
@ 2020-09-18 20:47 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:47 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:24 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> index fc6c81291cf5..6a3deca404b9 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> @@ -1103,7 +1103,7 @@ static void _rtl92c_phy_path_adda_on(struct ieee80211_hw *hw,
> u32 i;
>
> pathon = is_patha_on ? 0x04db25a4 : 0x0b1b25a4;
> - if (false == is2t) {
> + if (!is2t) {
> pathon = 0x0bdb25a0;
> rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0b1b25a0);
> } else {
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
2020-09-18 10:24 ` [PATCH -next 1/9] rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c Zheng Bin
2020-09-18 10:24 ` [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c Zheng Bin
@ 2020-09-18 10:24 ` Zheng Bin
2020-09-18 20:47 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c Zheng Bin
` (5 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:24 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:179:14-17: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:186:13-16: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index d7afb6a186df..2890a495a23e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
@@ -158,14 +158,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
for (i = 0; i < (boundary - 1); i++) {
rst = rtl92c_llt_write(hw, i , i + 1);
- if (true != rst) {
+ if (!rst) {
pr_err("===> %s #1 fail\n", __func__);
return rst;
}
}
/* end of list */
rst = rtl92c_llt_write(hw, (boundary - 1), 0xFF);
- if (true != rst) {
+ if (!rst) {
pr_err("===> %s #2 fail\n", __func__);
return rst;
}
@@ -176,14 +176,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
*/
for (i = boundary; i < LLT_LAST_ENTRY_OF_TX_PKT_BUFFER; i++) {
rst = rtl92c_llt_write(hw, i, (i + 1));
- if (true != rst) {
+ if (!rst) {
pr_err("===> %s #3 fail\n", __func__);
return rst;
}
}
/* Let last entry point to the start entry of ring buffer */
rst = rtl92c_llt_write(hw, LLT_LAST_ENTRY_OF_TX_PKT_BUFFER, boundary);
- if (true != rst) {
+ if (!rst) {
pr_err("===> %s #4 fail\n", __func__);
return rst;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c
2020-09-18 10:24 ` [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c Zheng Bin
@ 2020-09-18 20:47 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:47 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:24 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:179:14-17: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:186:13-16: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> index d7afb6a186df..2890a495a23e 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> @@ -158,14 +158,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
>
> for (i = 0; i < (boundary - 1); i++) {
> rst = rtl92c_llt_write(hw, i , i + 1);
> - if (true != rst) {
> + if (!rst) {
> pr_err("===> %s #1 fail\n", __func__);
> return rst;
> }
> }
> /* end of list */
> rst = rtl92c_llt_write(hw, (boundary - 1), 0xFF);
> - if (true != rst) {
> + if (!rst) {
> pr_err("===> %s #2 fail\n", __func__);
> return rst;
> }
> @@ -176,14 +176,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
> */
> for (i = boundary; i < LLT_LAST_ENTRY_OF_TX_PKT_BUFFER; i++) {
> rst = rtl92c_llt_write(hw, i, (i + 1));
> - if (true != rst) {
> + if (!rst) {
> pr_err("===> %s #3 fail\n", __func__);
> return rst;
> }
> }
> /* Let last entry point to the start entry of ring buffer */
> rst = rtl92c_llt_write(hw, LLT_LAST_ENTRY_OF_TX_PKT_BUFFER, boundary);
> - if (true != rst) {
> + if (!rst) {
> pr_err("===> %s #4 fail\n", __func__);
> return rst;
> }
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (2 preceding siblings ...)
2020-09-18 10:24 ` [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:47 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c Zheng Bin
` (4 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c:1897:5-13: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
index b2e5b9fda669..33ffc24d3675 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
@@ -1894,7 +1894,7 @@ int rtl8821ae_hw_init(struct ieee80211_hw *hw)
}
rtstatus = _rtl8821ae_init_mac(hw);
- if (rtstatus != true) {
+ if (!rtstatus) {
pr_err("Init MAC failed\n");
err = 1;
return err;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c
2020-09-18 10:25 ` [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c Zheng Bin
@ 2020-09-18 20:47 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:47 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c:1897:5-13: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index b2e5b9fda669..33ffc24d3675 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1894,7 +1894,7 @@ int rtl8821ae_hw_init(struct ieee80211_hw *hw)
> }
>
> rtstatus = _rtl8821ae_init_mac(hw);
> - if (rtstatus != true) {
> + if (!rtstatus) {
> pr_err("Init MAC failed\n");
> err = 1;
> return err;
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (3 preceding siblings ...)
2020-09-18 10:25 ` [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:48 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c Zheng Bin
` (3 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1839:5-13: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 7832fae3d00f..38669b4d6190 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -1813,7 +1813,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
BASEBAND_CONFIG_PHY_REG);
- if (rtstatus != true) {
+ if (!rtstatus) {
pr_err("Write BB Reg Fail!!\n");
return false;
}
@@ -1822,7 +1822,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
rtstatus = _rtl8821ae_phy_config_bb_with_pgheaderfile(hw,
BASEBAND_CONFIG_PHY_REG);
}
- if (rtstatus != true) {
+ if (!rtstatus) {
pr_err("BB_PG Reg Fail!!\n");
return false;
}
@@ -1836,7 +1836,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
BASEBAND_CONFIG_AGC_TAB);
- if (rtstatus != true) {
+ if (!rtstatus) {
pr_err("AGC Table Fail\n");
return false;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c
2020-09-18 10:25 ` [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c Zheng Bin
@ 2020-09-18 20:48 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:48 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1839:5-13: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> index 7832fae3d00f..38669b4d6190 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> @@ -1813,7 +1813,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
>
> rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
> BASEBAND_CONFIG_PHY_REG);
> - if (rtstatus != true) {
> + if (!rtstatus) {
> pr_err("Write BB Reg Fail!!\n");
> return false;
> }
> @@ -1822,7 +1822,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
> rtstatus = _rtl8821ae_phy_config_bb_with_pgheaderfile(hw,
> BASEBAND_CONFIG_PHY_REG);
> }
> - if (rtstatus != true) {
> + if (!rtstatus) {
> pr_err("BB_PG Reg Fail!!\n");
> return false;
> }
> @@ -1836,7 +1836,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
> rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
> BASEBAND_CONFIG_AGC_TAB);
>
> - if (rtstatus != true) {
> + if (!rtstatus) {
> pr_err("AGC Table Fail\n");
> return false;
> }
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (4 preceding siblings ...)
2020-09-18 10:25 ` [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:48 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 7/9] rtlwifi: rtl8192ce: " Zheng Bin
` (2 subsequent siblings)
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:831:14-49: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
index 3061bd81f39e..6312fddd9c00 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
@@ -828,7 +828,7 @@ static int _rtl92cu_init_mac(struct ieee80211_hw *hw)
? WMM_CHIP_B_TX_PAGE_BOUNDARY
: WMM_CHIP_A_TX_PAGE_BOUNDARY;
}
- if (false == rtl92c_init_llt_table(hw, boundary)) {
+ if (!rtl92c_init_llt_table(hw, boundary)) {
pr_err("Failed to init LLT Table!\n");
return -EINVAL;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c
2020-09-18 10:25 ` [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c Zheng Bin
@ 2020-09-18 20:48 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:48 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:831:14-49: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> index 3061bd81f39e..6312fddd9c00 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> @@ -828,7 +828,7 @@ static int _rtl92cu_init_mac(struct ieee80211_hw *hw)
> ? WMM_CHIP_B_TX_PAGE_BOUNDARY
> : WMM_CHIP_A_TX_PAGE_BOUNDARY;
> }
> - if (false == rtl92c_init_llt_table(hw, boundary)) {
> + if (!rtl92c_init_llt_table(hw, boundary)) {
> pr_err("Failed to init LLT Table!\n");
> return -EINVAL;
> }
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 7/9] rtlwifi: rtl8192ce: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (5 preceding siblings ...)
2020-09-18 10:25 ` [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:49 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 8/9] rtlwifi: rtl8192de: " Zheng Bin
2020-09-18 10:25 ` [PATCH -next 9/9] rtlwifi: rtl8723be: " Zheng Bin
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:616:14-20: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:621:13-19: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:626:14-20: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:631:13-19: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
index d4cd186036fd..bb5a0c4aec93 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
@@ -613,22 +613,22 @@ static bool _rtl92ce_llt_table_init(struct ieee80211_hw *hw)
for (i = 0; i < (txpktbuf_bndy - 1); i++) {
status = _rtl92ce_llt_write(hw, i, i + 1);
- if (true != status)
+ if (!status)
return status;
}
status = _rtl92ce_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
- if (true != status)
+ if (!status)
return status;
for (i = txpktbuf_bndy; i < maxpage; i++) {
status = _rtl92ce_llt_write(hw, i, (i + 1));
- if (true != status)
+ if (!status)
return status;
}
status = _rtl92ce_llt_write(hw, maxpage, txpktbuf_bndy);
- if (true != status)
+ if (!status)
return status;
return true;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 7/9] rtlwifi: rtl8192ce: fix comparison to bool warning in hw.c
2020-09-18 10:25 ` [PATCH -next 7/9] rtlwifi: rtl8192ce: " Zheng Bin
@ 2020-09-18 20:49 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:49 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:616:14-20: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:621:13-19: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:626:14-20: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:631:13-19: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
> index d4cd186036fd..bb5a0c4aec93 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
> @@ -613,22 +613,22 @@ static bool _rtl92ce_llt_table_init(struct ieee80211_hw *hw)
>
> for (i = 0; i < (txpktbuf_bndy - 1); i++) {
> status = _rtl92ce_llt_write(hw, i, i + 1);
> - if (true != status)
> + if (!status)
> return status;
> }
>
> status = _rtl92ce_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
> - if (true != status)
> + if (!status)
> return status;
>
> for (i = txpktbuf_bndy; i < maxpage; i++) {
> status = _rtl92ce_llt_write(hw, i, (i + 1));
> - if (true != status)
> + if (!status)
> return status;
> }
>
> status = _rtl92ce_llt_write(hw, maxpage, txpktbuf_bndy);
> - if (true != status)
> + if (!status)
> return status;
>
> return true;
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 8/9] rtlwifi: rtl8192de: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (6 preceding siblings ...)
2020-09-18 10:25 ` [PATCH -next 7/9] rtlwifi: rtl8192ce: " Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:49 ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 9/9] rtlwifi: rtl8723be: " Zheng Bin
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:566:14-20: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:572:13-19: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:581:14-20: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:587:13-19: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
index 2deadc7339ce..f849291cc587 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
@@ -563,13 +563,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw)
/* 18. LLT_table_init(Adapter); */
for (i = 0; i < (txpktbuf_bndy - 1); i++) {
status = _rtl92de_llt_write(hw, i, i + 1);
- if (true != status)
+ if (!status)
return status;
}
/* end of list */
status = _rtl92de_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
- if (true != status)
+ if (!status)
return status;
/* Make the other pages as ring buffer */
@@ -578,13 +578,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw)
/* Otherwise used as local loopback buffer. */
for (i = txpktbuf_bndy; i < maxpage; i++) {
status = _rtl92de_llt_write(hw, i, (i + 1));
- if (true != status)
+ if (!status)
return status;
}
/* Let last entry point to the start entry of ring buffer */
status = _rtl92de_llt_write(hw, maxpage, txpktbuf_bndy);
- if (true != status)
+ if (!status)
return status;
return true;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 8/9] rtlwifi: rtl8192de: fix comparison to bool warning in hw.c
2020-09-18 10:25 ` [PATCH -next 8/9] rtlwifi: rtl8192de: " Zheng Bin
@ 2020-09-18 20:49 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:49 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:566:14-20: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:572:13-19: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:581:14-20: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:587:13-19: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
> index 2deadc7339ce..f849291cc587 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
> @@ -563,13 +563,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw)
> /* 18. LLT_table_init(Adapter); */
> for (i = 0; i < (txpktbuf_bndy - 1); i++) {
> status = _rtl92de_llt_write(hw, i, i + 1);
> - if (true != status)
> + if (!status)
> return status;
> }
>
> /* end of list */
> status = _rtl92de_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
> - if (true != status)
> + if (!status)
> return status;
>
> /* Make the other pages as ring buffer */
> @@ -578,13 +578,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw)
> /* Otherwise used as local loopback buffer. */
> for (i = txpktbuf_bndy; i < maxpage; i++) {
> status = _rtl92de_llt_write(hw, i, (i + 1));
> - if (true != status)
> + if (!status)
> return status;
> }
>
> /* Let last entry point to the start entry of ring buffer */
> status = _rtl92de_llt_write(hw, maxpage, txpktbuf_bndy);
> - if (true != status)
> + if (!status)
> return status;
>
> return true;
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
` (7 preceding siblings ...)
2020-09-18 10:25 ` [PATCH -next 8/9] rtlwifi: rtl8192de: " Zheng Bin
@ 2020-09-18 10:25 ` Zheng Bin
2020-09-18 20:49 ` Larry Finger
8 siblings, 1 reply; 19+ messages in thread
From: Zheng Bin @ 2020-09-18 10:25 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
index 3c7ba8214daf..0748aedce2ad 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
@@ -858,7 +858,7 @@ static bool _rtl8723be_init_mac(struct ieee80211_hw *hw)
rtl_write_word(rtlpriv, REG_CR, 0x2ff);
if (!rtlhal->mac_func_enable) {
- if (_rtl8723be_llt_table_init(hw) == false)
+ if (!_rtl8723be_llt_table_init(hw))
return false;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c
2020-09-18 10:25 ` [PATCH -next 9/9] rtlwifi: rtl8723be: " Zheng Bin
@ 2020-09-18 20:49 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2020-09-18 20:49 UTC (permalink / raw)
To: Zheng Bin, pkshih, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: yi.zhang
On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> index 3c7ba8214daf..0748aedce2ad 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> @@ -858,7 +858,7 @@ static bool _rtl8723be_init_mac(struct ieee80211_hw *hw)
> rtl_write_word(rtlpriv, REG_CR, 0x2ff);
>
> if (!rtlhal->mac_func_enable) {
> - if (_rtl8723be_llt_table_init(hw) == false)
> + if (!_rtl8723be_llt_table_init(hw))
> return false;
> }
>
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 19+ messages in thread