From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145FCC43465 for ; Mon, 21 Sep 2020 14:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBC2C22262 for ; Mon, 21 Sep 2020 14:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgIUO0B (ORCPT ); Mon, 21 Sep 2020 10:26:01 -0400 Received: from verein.lst.de ([213.95.11.211]:40266 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgIUO0B (ORCPT ); Mon, 21 Sep 2020 10:26:01 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 241E068B02; Mon, 21 Sep 2020 16:25:58 +0200 (CEST) Date: Mon, 21 Sep 2020 16:25:57 +0200 From: Christoph Hellwig To: Coly Li Cc: David Miller , hch@lst.de, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bypass ->sendpage for slab pages Message-ID: <20200921142557.GA16775@lst.de> References: <20200819051945.1797088-1-hch@lst.de> <20200819.120709.1311664171016372891.davem@davemloft.net> <20200820043744.GA4349@lst.de> <20200821.141400.594703865403700191.davem@davemloft.net> <903c7e2c-100f-267f-efd8-b0b3345dc918@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <903c7e2c-100f-267f-efd8-b0b3345dc918@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 18, 2020 at 04:37:24PM +0800, Coly Li wrote: > Hi David and Christoph, > > It has been quiet for a while, what should we go next for the > kernel_sendpage() related issue ? > > Will Christoph's or my series be considered as proper fix, or maybe I > should wait for some other better idea to show up? Any is OK for me, > once the problem is fixed. I think for all the network storage stuff we really need a "send me out a page helper", and the nvmet bits that Dave pointed to look to me like they actually are currently broken. Given that Dave doesn't want to change the kernel_sendpage semantics I'll resend with a new helper instead. Any preferences for a name? safe_sendpage? kernel_sendpage_safe? kernel_send_one_page?