From: David Miller <davem@davemloft.net>
To: geert+renesas@glider.be
Cc: kuba@kernel.org, ashiduka@fujitsu.com, sergei.shtylyov@gmail.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"
Date: Wed, 23 Sep 2020 17:40:04 -0700 (PDT) [thread overview]
Message-ID: <20200923.174004.2129776473634492661.davem@davemloft.net> (raw)
In-Reply-To: <20200922072931.2148-1-geert+renesas@glider.be>
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Tue, 22 Sep 2020 09:29:31 +0200
> This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc.
>
> This commit moved the ravb_mdio_init() call (and thus the
> of_mdiobus_register() call) from the ravb_probe() to the ravb_open()
> call. This causes a regression during system resume (s2idle/s2ram), as
> new PHY devices cannot be bound while suspended.
...
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: stable@vger.kernel.org
I noticed this too late, but please don't CC: stable on networking
patches. We have our own workflow as per the netdev FAQ.
I've applied this but the inability to remove a module is an
extremely serious bug and should be fixed properly.
next prev parent reply other threads:[~2020-09-24 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:29 [PATCH net] Revert "ravb: Fixed to be able to unload modules" Geert Uytterhoeven
2020-09-22 9:53 ` Sergei Shtylyov
2020-09-24 0:40 ` David Miller [this message]
2020-09-24 7:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923.174004.2129776473634492661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).