From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd
Date: Wed, 23 Sep 2020 14:58:24 -0600 [thread overview]
Message-ID: <20200923205824.GA1290651@bogus> (raw)
In-Reply-To: <20200918181104.98-2-ansuelsmth@gmail.com>
On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> define from where the driver will load the pre-cal data in the defined
> mtd partition.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index b61c2d5a0..568364243 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -15,9 +15,9 @@ and also uses most of the properties defined in this doc (except
> "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
> to carry pre calibration data.
>
> -In general, entry "qcom,ath10k-pre-calibration-data" and
> -"qcom,ath10k-calibration-data" conflict with each other and only one
> -can be provided per device.
> +In general, entry "qcom,ath10k-pre-calibration-data",
> +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-data" conflict with
> +each other and only one can be provided per device.
>
> SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
>
> @@ -63,6 +63,12 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- qcom,ath10k-pre-calibration-data-mtd :
mtd is a Linuxism.
> + Usage: optional
> + Value type: <phandle offset size>
> + Definition: pre calibration data read from mtd partition. Take 3 value, the
> + mtd to read data from, the offset in the mtd partition and the
The phandle is the mtd or partition?
Maybe you should be using nvmem binding here.
> + size of data to read.
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" are "vdd-0.8-cx-mx",
> "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-09-23 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 18:11 [PATCH v2 1/2] ath10k: Introduce download cal from mtd Ansuel Smith
2020-09-18 18:11 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd Ansuel Smith
2020-09-23 20:58 ` Rob Herring [this message]
2020-09-23 21:04 ` ansuelsmth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923205824.GA1290651@bogus \
--to=robh@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).