netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] build: avoid make jobserver warnings
Date: Thu, 24 Sep 2020 09:11:07 -0700	[thread overview]
Message-ID: <20200924091107.1f11508c@hermes.lan> (raw)
In-Reply-To: <nycvar.YFH.7.78.908.2009220812330.10964@n3.vanv.qr>

On Tue, 22 Sep 2020 08:15:59 +0200 (CEST)
Jan Engelhardt <jengelh@inai.de> wrote:

> On Tuesday 2020-09-22 02:19, Stephen Hemminger wrote:
> >> I observe:
> >> 
> >> 	» make -j8 CCOPTS=-ggdb3
> >> 	lib
> >> 	make[1]: warning: -j8 forced in submake: resetting jobserver mode.
> >> 	make[1]: Nothing to be done for 'all'.
> >> 	ip
> >> 	make[1]: warning: -j8 forced in submake: resetting jobserver mode.
> >> 	    CC       ipntable.o
> >> 
> >> MFLAGS is a historic variable of some kind; removing it fixes the
> >> jobserver issue.  
> >
> >MFLAGS is a way to pass flags from original make into the sub-make.  
> 
> MAKEFLAGS and MFLAGS are already exported by make (${MAKE} is magic
> methinks), so they need no explicit passing. You can check this by
> adding something like 'echo ${MAKEFLAGS}' to the lib/Makefile
> libnetlink.a target and then invoking e.g. `make -r` from the
> toplevel, and notice how -r shows up again in the submake.

For context:
https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html

With your change does the options through the same?
My concern is that this change might break how distros do their package builds,
and cross compilation.

  reply	other threads:[~2020-09-24 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 23:22 [PATCH iproute2] build: avoid make jobserver warnings Jan Engelhardt
2020-09-22  0:19 ` Stephen Hemminger
2020-09-22  6:15   ` Jan Engelhardt
2020-09-24 16:11     ` Stephen Hemminger [this message]
2020-09-24 16:56       ` Jan Engelhardt
2020-09-28 15:39         ` Stephen Hemminger
     [not found]           ` <20200928190801.561-1-jengelh@inai.de>
2020-09-28 20:52             ` [iproute PATCH] " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924091107.1f11508c@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=jengelh@inai.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).