From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 625B3C4727E for ; Thu, 24 Sep 2020 19:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03CE9221EB for ; Thu, 24 Sep 2020 19:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbgIXTcZ (ORCPT ); Thu, 24 Sep 2020 15:32:25 -0400 Received: from mga17.intel.com ([192.55.52.151]:24657 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbgIXTcZ (ORCPT ); Thu, 24 Sep 2020 15:32:25 -0400 IronPort-SDR: XnQslgfioWbLlkJO5tr/dIipgsPnndZvf/oThS5526YhbNEDDa5PeLv8zbZYc5J/0/BjeLJtKu t44th3rcMKIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="141333506" X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="141333506" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 12:32:25 -0700 IronPort-SDR: 1pfq+OAgEiSwB4AeF3hmaszVBhe2sxt5b0Ts5MPJpMAViOE+gvoRXZ6TwG1gy/Fq5C6r20EAOd dBvbA9Qy4O+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="291356077" Received: from ranger.igk.intel.com ([10.102.21.164]) by fmsmga007.fm.intel.com with ESMTP; 24 Sep 2020 12:32:23 -0700 Date: Thu, 24 Sep 2020 21:25:08 +0200 From: Maciej Fijalkowski To: Daniel Borkmann Cc: ast@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next 5/6] bpf, selftests: use bpf_tail_call_static where appropriate Message-ID: <20200924192508.GA34764@ranger.igk.intel.com> References: <0c8a5df84b2f174412c252ad32734d3545947b31.1600967205.git.daniel@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c8a5df84b2f174412c252ad32734d3545947b31.1600967205.git.daniel@iogearbox.net> User-Agent: Mutt/1.12.1 (2019-06-15) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 24, 2020 at 08:21:26PM +0200, Daniel Borkmann wrote: > For those locations where we use an immediate tail call map index use the > newly added bpf_tail_call_static() helper. > > Signed-off-by: Daniel Borkmann > --- > tools/testing/selftests/bpf/progs/bpf_flow.c | 12 ++++---- > tools/testing/selftests/bpf/progs/tailcall1.c | 28 +++++++++---------- > tools/testing/selftests/bpf/progs/tailcall2.c | 14 +++++----- > tools/testing/selftests/bpf/progs/tailcall3.c | 4 +-- > .../selftests/bpf/progs/tailcall_bpf2bpf1.c | 4 +-- > .../selftests/bpf/progs/tailcall_bpf2bpf2.c | 6 ++-- > .../selftests/bpf/progs/tailcall_bpf2bpf3.c | 6 ++-- > .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 6 ++-- > 8 files changed, 40 insertions(+), 40 deletions(-) One nit, while you're at it, maybe it would be good to also address the samples/bpf/sockex3_kern.c that is also using the immediate map index? [...]