From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>
Subject: Re: [PATCH v2 net-next 02/16] net: dsa: allow drivers to request promiscuous mode on master
Date: Sat, 26 Sep 2020 17:55:39 +0000 [thread overview]
Message-ID: <20200926175538.amkogkm4qt6azudc@skbuf> (raw)
In-Reply-To: <20200926174700.GB3883417@lunn.ch>
On Sat, Sep 26, 2020 at 07:47:00PM +0200, Andrew Lunn wrote:
> Hi Vladimir
>
> I actually think this is a property of the tagger, not the DSA
> driver. In fact, DSA drivers never handle actual frames, they are all
> about the control plane, not the data plane. So i think this bool
> should be in the tagger structure, dsa_device_ops.
This is actually a good comment that will simplify my future work a
little bit. I need to add a Kconfig-selectable tagger for the Felix
driver (tag_ocelot.c vs a future tag_ocelot_8021q.c) and, predictably
enough, one tagger needs promisc on master while the other doesn't.
If you have no other comments on this series, I'm thinking about
resending it right away with this change, since I made a big blunder and
the people in Cc on the tagger patches were not actually copied to my
emails, since I have supresscc=all in my .gitconfig.
next prev parent reply other threads:[~2020-09-26 17:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 17:30 [PATCH v2 net-next 00/16] Generic adjustment for flow dissector in DSA Vladimir Oltean
2020-09-26 17:30 ` [PATCH v2 net-next 01/16] net: mscc: ocelot: move NPI port configuration to DSA Vladimir Oltean
2020-09-26 17:30 ` [PATCH v2 net-next 02/16] net: dsa: allow drivers to request promiscuous mode on master Vladimir Oltean
2020-09-26 17:47 ` Andrew Lunn
2020-09-26 17:55 ` Vladimir Oltean [this message]
2020-09-26 17:30 ` [PATCH v2 net-next 03/16] net: dsa: sja1105: request promiscuous mode for master Vladimir Oltean
2020-09-26 17:30 ` [PATCH v2 net-next 04/16] net: dsa: tag_ocelot: use a short prefix on both ingress and egress Vladimir Oltean
2020-09-26 17:30 ` [PATCH v2 net-next 05/16] net: dsa: make the .flow_dissect tagger callback return void Vladimir Oltean
2020-09-26 17:49 ` Andrew Lunn
2020-09-26 17:30 ` [PATCH v2 net-next 06/16] net: dsa: add a generic procedure for the flow dissector Vladimir Oltean
2020-09-26 18:05 ` Andrew Lunn
2020-09-26 18:18 ` Vladimir Oltean
2020-09-26 18:28 ` Andrew Lunn
2020-09-26 18:13 ` Andrew Lunn
2020-09-26 17:30 ` [PATCH v2 net-next 07/16] net: dsa: tag_ar8331: use generic flow dissector procedure Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 08/16] net: dsa: tag_brcm: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 09/16] net: dsa: tag_dsa: use the " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 10/16] net: dsa: tag_edsa: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 11/16] net: dsa: tag_lan9303: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 12/16] net: dsa: tag_mtk: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 13/16] net: dsa: tag_ocelot: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 14/16] net: dsa: tag_qca: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 15/16] net: dsa: tag_sja1105: " Vladimir Oltean
2020-09-26 17:31 ` [PATCH v2 net-next 16/16] net: dsa: tag_rtl4_a: " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926175538.amkogkm4qt6azudc@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox