From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DDBC2D0A8 for ; Sat, 26 Sep 2020 20:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 928F6235FD for ; Sat, 26 Sep 2020 20:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgIZUdC (ORCPT ); Sat, 26 Sep 2020 16:33:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57226 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbgIZUdC (ORCPT ); Sat, 26 Sep 2020 16:33:02 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kMGsO-00GJSO-JW; Sat, 26 Sep 2020 22:33:00 +0200 Date: Sat, 26 Sep 2020 22:33:00 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: netdev@vger.kernel.org, davem@davemloft.net, f.fainelli@gmail.com, vivien.didelot@gmail.com, kuba@kernel.org Subject: Re: [PATCH v3 net-next 06/15] net: dsa: add a generic procedure for the flow dissector Message-ID: <20200926203300.GE3887691@lunn.ch> References: <20200926193215.1405730-1-vladimir.oltean@nxp.com> <20200926193215.1405730-7-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200926193215.1405730-7-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static inline void dsa_tag_generic_flow_dissect(const struct sk_buff *skb, > + __be16 *proto, int *offset) > +{ > +#if IS_ENABLED(CONFIG_NET_DSA) > + const struct dsa_device_ops *ops = skb->dev->dsa_ptr->tag_ops; > + int tag_len = ops->overhead; > + > + *offset = tag_len; > + *proto = ((__be16 *)skb->data)[(tag_len / 2) - 1]; > +#endif > +} > + Do you actually need the IS_ENABLED()? There is only one caller of this function, and it is already protected by IS_ENABLED(CONFIG_NET_DSA). So i don't think it adds anything. Andrew