From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jiri Pirko <jiri@nvidia.com>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour
Date: Sun, 27 Sep 2020 00:51:47 +0300 [thread overview]
Message-ID: <20200926215147.w7xjlozqs6i5pffm@skbuf> (raw)
In-Reply-To: <20200926210632.3888886-2-andrew@lunn.ch>
On Sat, Sep 26, 2020 at 11:06:26PM +0200, Andrew Lunn wrote:
> Not all ports of a switch need to be used, particularly in embedded
> systems. Add a port flavour for ports which physically exist in the
> switch, but are not connected to the front panel etc, and so are
> unused.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> include/uapi/linux/devlink.h | 3 +++
> net/core/devlink.c | 4 +++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index a2ecc8b00611..e1f209feac74 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -195,6 +195,9 @@ enum devlink_port_flavour {
> * port that faces the PCI VF.
> */
> DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
> + DEVLINK_PORT_FLAVOUR_UNUSED, /* Port which exists in the switch, but
> + * is not used in any way.
Nitpicking: there is an extraneous tab character here between "*" and "is".
> + */
> };
>
> enum devlink_param_cmode {
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index ac32b672a04b..fc9589eb4115 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -7569,7 +7569,8 @@ static bool devlink_port_type_should_warn(struct devlink_port *devlink_port)
> {
> /* Ignore CPU and DSA flavours. */
> return devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_CPU &&
> - devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_DSA;
> + devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_DSA &&
> + devlink_port->attrs.flavour != DEVLINK_PORT_FLAVOUR_UNUSED;
> }
>
> #define DEVLINK_PORT_TYPE_WARN_TIMEOUT (HZ * 3600)
> @@ -7854,6 +7855,7 @@ static int __devlink_port_phys_port_name_get(struct devlink_port *devlink_port,
> break;
> case DEVLINK_PORT_FLAVOUR_CPU:
> case DEVLINK_PORT_FLAVOUR_DSA:
> + case DEVLINK_PORT_FLAVOUR_UNUSED:
> /* As CPU and DSA ports do not have a netdevice associated
> * case should not ever happen.
> */
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-26 21:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 21:06 [PATCH net-next v2 0/7] mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 1/7] net: devlink: Add unused port flavour Andrew Lunn
2020-09-26 21:51 ` Vladimir Oltean [this message]
2020-09-26 22:00 ` Vladimir Oltean
2020-09-27 0:33 ` Andrew Lunn
2020-09-28 21:31 ` Jakub Kicinski
2020-09-28 22:05 ` Vladimir Oltean
2020-09-28 22:07 ` Andrew Lunn
2020-09-28 22:35 ` Jakub Kicinski
2020-09-28 22:36 ` Florian Fainelli
2020-09-28 23:39 ` Jakub Kicinski
2020-09-29 1:46 ` Florian Fainelli
2020-09-29 11:03 ` Vladimir Oltean
2020-09-29 13:07 ` Jiri Pirko
2020-09-29 13:48 ` Vladimir Oltean
2020-09-29 15:12 ` Jiri Pirko
2020-09-29 13:57 ` Andrew Lunn
2020-09-30 6:56 ` Jiri Pirko
2020-09-30 13:57 ` Andrew Lunn
2020-09-30 14:34 ` Jiri Pirko
2020-09-30 14:53 ` Andrew Lunn
2020-10-01 7:39 ` Jiri Pirko
2020-09-26 21:06 ` [PATCH net-next v2 2/7] net: dsa: Make use of devlink port flavour unused Andrew Lunn
2020-09-26 22:51 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 3/7] net: dsa: Register devlink ports before calling DSA driver setup() Andrew Lunn
2020-09-26 23:37 ` Vladimir Oltean
2020-09-27 0:45 ` Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 4/7] net: devlink: Add support for port regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 5/7] net: dsa: Add devlink port regions support to DSA Andrew Lunn
2020-09-26 23:42 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 6/7] net: dsa: Add helper for converting devlink port to ds and port Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 23:52 ` Vladimir Oltean
2020-09-27 1:03 ` Andrew Lunn
2020-09-27 1:11 ` Vladimir Oltean
2020-09-26 22:02 ` [PATCH net-next v2 0/7] " Marek Behun
2020-09-26 22:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926215147.w7xjlozqs6i5pffm@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox