From: Andrew Lunn <andrew@lunn.ch>
To: Marek Behun <marek.behun@nic.cz>
Cc: netdev <netdev@vger.kernel.org>,
linux-leds@vger.kernel.org, David Miller <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>
Subject: Re: Request for Comment: LED device naming for netdev LEDs
Date: Sun, 27 Sep 2020 03:13:06 +0200 [thread overview]
Message-ID: <20200927011306.GE3889809@lunn.ch> (raw)
In-Reply-To: <20200927024522.06df813f@nic.cz>
> So I will have
> /sys/class/net/eth0/phydev/leds/eth0:green:activity
> | |
> symlink |
> |
> symlink
>
> and I will also have
> /sys/class/leds/eth0:green:activity
> |
> symlink
So this forces the name to be globally unique, not netns unique. So
you cannot use the interface name alone.
i don't think the name is actually too important. You are going to
find it via /sys/class/net/eth0/phydev/leds/eth0:green:activity so the
proposal of an incremental number works.
Andrew
next prev parent reply other threads:[~2020-09-27 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 22:40 Request for Comment: LED device naming for netdev LEDs Marek Behun
2020-09-27 0:29 ` Andrew Lunn
2020-09-27 0:45 ` Marek Behun
2020-09-27 1:13 ` Andrew Lunn [this message]
2020-09-27 0:52 ` Marek Behun
2020-09-28 13:04 ` Alexander Dahl
2020-09-28 15:52 ` Marek Behun
2020-09-28 17:10 ` Alexander Dahl
2020-09-28 17:22 ` Marek Behun
2020-11-25 10:59 ` Pavel Machek
2020-11-25 10:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927011306.GE3889809@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).