From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
mkubecek@suse.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH net-next v5 2/2] net: phy: dp83869: Add speed optimization feature
Date: Mon, 28 Sep 2020 21:34:12 +0200 [thread overview]
Message-ID: <20200928193412.GC3950513@lunn.ch> (raw)
In-Reply-To: <20200928145135.20847-3-dmurphy@ti.com>
On Mon, Sep 28, 2020 at 09:51:35AM -0500, Dan Murphy wrote:
> Set the speed optimization bit on the DP83869 PHY.
>
> Speed optimization, also known as link downshift, enables fallback to 100M
> operation after multiple consecutive failed attempts at Gigabit link
> establishment. Such a case could occur if cabling with only four wires
> (two twisted pairs) were connected instead of the standard cabling with
> eight wires (four twisted pairs).
>
> The number of failed link attempts before falling back to 100M operation is
> configurable. By default, four failed link attempts are required before
> falling back to 100M.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> + default:
> + phydev_err(phydev,
> + "Downshift count must be 1, 2, 4 or 8\n");
> + return -EINVAL;
> + }
At some point it would be good to plumb in extack so we could return
this to user space.
Andrew
next prev parent reply other threads:[~2020-09-28 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 14:51 [RESEND PATCH net-next v5 0/2] DP83869 WoL and Speed optimization Dan Murphy
2020-09-28 14:51 ` [RESEND PATCH net-next v5 1/2] net: phy: dp83869: support Wake on LAN Dan Murphy
2020-09-28 19:28 ` Andrew Lunn
2020-09-28 14:51 ` [RESEND PATCH net-next v5 2/2] net: phy: dp83869: Add speed optimization feature Dan Murphy
2020-09-28 19:34 ` Andrew Lunn [this message]
2020-09-28 19:44 ` [RESEND PATCH net-next v5 0/2] DP83869 WoL and Speed optimization David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928193412.GC3950513@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).