From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3817C2D0A8 for ; Tue, 29 Sep 2020 01:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B07EE2080A for ; Tue, 29 Sep 2020 01:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601343192; bh=XHhT+BWI5pRqE+V74UmBpgVn+ChE0exEXSay7jL+qHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OjEquq0K8MCaCdNH4a+sirCya5Pc50VqSBvEU3j2t36nxeCpP1ZwhDe+QqwjAKk7T Q3+DPKmRJFsuwmOtlEU++hWmVDbVZqmOqwg8+GVJmQv8t/eeOk581zisxf8pNkTcwU n60eqjE6Mg9V08lFGECLiTs8OKR6yZpoJE35/7wk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbgI2Bc7 (ORCPT ); Mon, 28 Sep 2020 21:32:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:41828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbgI2BcI (ORCPT ); Mon, 28 Sep 2020 21:32:08 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06838221E7; Tue, 29 Sep 2020 01:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601343120; bh=XHhT+BWI5pRqE+V74UmBpgVn+ChE0exEXSay7jL+qHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZcNGD3C1cO8wc9UvvsdI7BSs7km3jsh3Ov5CWEEY9zbLka57Lvi2RlpeZKnxnQZeo j5loQBYAquhAIo52z+LsGxgUikwG8R+hHQCd1W5JvxKq2weR6JfecthfP7GELBZSoe MnRB+ieeok5B69FRTZoQ5qeAUsqlwWnMIsS5qfwE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Olympia Giannou , Olympia Giannou , "David S . Miller" , Sasha Levin , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 2/5] rndis_host: increase sleep time in the query-response loop Date: Mon, 28 Sep 2020 21:31:54 -0400 Message-Id: <20200929013157.2407108-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200929013157.2407108-1-sashal@kernel.org> References: <20200929013157.2407108-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Olympia Giannou [ Upstream commit 4202c9fdf03d79dedaa94b2c4cf574f25793d669 ] Some WinCE devices face connectivity issues via the NDIS interface. They fail to register, resulting in -110 timeout errors and failures during the probe procedure. In this kind of WinCE devices, the Windows-side ndis driver needs quite more time to be loaded and configured, so that the linux rndis host queries to them fail to be responded correctly on time. More specifically, when INIT is called on the WinCE side - no other requests can be served by the Client and this results in a failed QUERY afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Signed-off-by: Olympia Giannou Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index 4f4f71b2966ba..9ccbdf1431063 100644 --- a/drivers/net/usb/rndis_host.c +++ b/drivers/net/usb/rndis_host.c @@ -213,7 +213,7 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen) dev_dbg(&info->control->dev, "rndis response error, code %d\n", retval); } - msleep(20); + msleep(40); } dev_dbg(&info->control->dev, "rndis response timeout\n"); return -ETIMEDOUT; -- 2.25.1