From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, clew@codeaurora.org,
manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH 1/2] net: qrtr: Allow forwarded services
Date: Tue, 29 Sep 2020 09:34:19 -0500 [thread overview]
Message-ID: <20200929143419.GD71055@builder.lan> (raw)
In-Reply-To: <1601386397-21067-1-git-send-email-loic.poulain@linaro.org>
On Tue 29 Sep 08:33 CDT 2020, Loic Poulain wrote:
> A remote endpoint (immediate neighbor node) can forward services
> from other non-immediate nodes, in that case ctrl packet node ID
> (offering distant service) can differ from the qrtr source node
> (forwarding the packet).
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> net/qrtr/ns.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
> index d8252fd..d542d8f 100644
> --- a/net/qrtr/ns.c
> +++ b/net/qrtr/ns.c
> @@ -469,10 +469,6 @@ static int ctrl_cmd_new_server(struct sockaddr_qrtr *from,
> port = from->sq_port;
> }
>
> - /* Don't accept spoofed messages */
> - if (from->sq_node != node_id)
> - return -EINVAL;
> -
> srv = server_add(service, instance, node_id, port);
> if (!srv)
> return -EINVAL;
> @@ -511,10 +507,6 @@ static int ctrl_cmd_del_server(struct sockaddr_qrtr *from,
> port = from->sq_port;
> }
>
> - /* Don't accept spoofed messages */
> - if (from->sq_node != node_id)
> - return -EINVAL;
> -
> /* Local servers may only unregister themselves */
> if (from->sq_node == qrtr_ns.local_node && from->sq_port != port)
> return -EINVAL;
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-09-29 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 13:33 [PATCH 1/2] net: qrtr: Allow forwarded services Loic Poulain
2020-09-29 13:33 ` [PATCH 2/2] net: qrtr: Allow non-immediate node routing Loic Poulain
2020-09-29 14:41 ` Bjorn Andersson
2020-09-29 15:55 ` Jakub Kicinski
2020-09-29 14:34 ` Bjorn Andersson [this message]
2020-10-01 13:26 ` [PATCH 1/2] net: qrtr: Allow forwarded services Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929143419.GD71055@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=davem@davemloft.net \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).