From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 2/3] net: atlantic: implement phy downshift feature
Date: Tue, 29 Sep 2020 19:10:30 +0200 [thread overview]
Message-ID: <20200929171030.GC3996795@lunn.ch> (raw)
In-Reply-To: <20200929161307.542-3-irusskikh@marvell.com>
> +int aq_nic_set_downshift(struct aq_nic_s *self)
> +{
> + int err = 0;
> + struct aq_nic_cfg_s *cfg = &self->aq_nic_cfg;
> +
> + if (!self->aq_fw_ops->set_downshift)
> + return -EOPNOTSUPP;
> +
> + if (ATL_HW_IS_CHIP_FEATURE(self->aq_hw, ANTIGUA)) {
> + if (cfg->downshift_counter > 15)
> + cfg->downshift_counter = 15;
> + } else {
> + if (cfg->downshift_counter > 255)
> + cfg->downshift_counter = 255;
> + }
Hi Igor
I think all other implementations return -EINVAL or -E2BIG or similar
when the value is not supported.
Also, given that a u8 is being passed, is cfg->downshift_counter > 255
possible? I'm not even sure 255 makes any sense. Autoneg takes around
1.5s, maybe longer. Do you really want to wait 255 * 1.5 seconds
before downshifting? Even 15*1.5 seems a long time.
Andrew
next prev parent reply other threads:[~2020-09-29 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:13 [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 1/3] ethtool: allow netdev driver to define phy tunables Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 2/3] net: atlantic: implement phy downshift feature Igor Russkikh
2020-09-29 17:10 ` Andrew Lunn [this message]
2020-09-30 8:34 ` Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables Igor Russkikh
2020-09-29 17:18 ` Andrew Lunn
2020-09-30 8:37 ` Igor Russkikh
2020-09-30 14:22 ` Andrew Lunn
2020-10-01 10:18 ` [EXT] " Igor Russkikh
2020-10-01 12:56 ` Andrew Lunn
2020-09-29 17:04 ` [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Andrew Lunn
2020-09-29 17:33 ` Jakub Kicinski
2020-09-29 18:47 ` Andrew Lunn
2020-09-30 0:09 ` Jakub Kicinski
2020-09-30 0:16 ` Andrew Lunn
2020-09-30 15:03 ` ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver) Michal Kubecek
2020-09-30 15:16 ` Andrew Lunn
2020-09-30 15:31 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929171030.GC3996795@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).