From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Igor Russkikh <irusskikh@marvell.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver
Date: Wed, 30 Sep 2020 02:16:40 +0200 [thread overview]
Message-ID: <20200930001640.GB4012000@lunn.ch> (raw)
In-Reply-To: <20200929170948.545826c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, Sep 29, 2020 at 05:09:48PM -0700, Jakub Kicinski wrote:
> On Tue, 29 Sep 2020 20:47:23 +0200 Andrew Lunn wrote:
> > > Do you mean report supported range via extack?
> >
> > Yes.
> >
> > 811ac400ea33 ("net: phy: dp83869: Add speed optimization feature")
> >
> > was merged recently. It has:
> >
> > + default:
> > + phydev_err(phydev,
> > + "Downshift count must be 1, 2, 4 or 8\n");
> > + return -EINVAL;
> >
> > and there are more examples in PHY drivers where it would be good to
> > tell the uses what the valid values are. I guess most won't see this
> > kernel message, but if netlink ethtool printed:
> >
> > Invalid Argument: Downshift count must be 1, 2, 4 or 8
> >
> > it would be a lot more user friendly.
>
> Ah, now I recall, we already discussed this.
>
> FWIW we could provision for the extack and just pass NULL for now?
> Would that be too ugly?
If Michal does not have any code lying around in a drawer, what might
be a good idea. For the old IOCTL we will need to pass a NULL anyway.
Andrew
next prev parent reply other threads:[~2020-09-30 0:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:13 [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 1/3] ethtool: allow netdev driver to define phy tunables Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 2/3] net: atlantic: implement phy downshift feature Igor Russkikh
2020-09-29 17:10 ` Andrew Lunn
2020-09-30 8:34 ` Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables Igor Russkikh
2020-09-29 17:18 ` Andrew Lunn
2020-09-30 8:37 ` Igor Russkikh
2020-09-30 14:22 ` Andrew Lunn
2020-10-01 10:18 ` [EXT] " Igor Russkikh
2020-10-01 12:56 ` Andrew Lunn
2020-09-29 17:04 ` [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Andrew Lunn
2020-09-29 17:33 ` Jakub Kicinski
2020-09-29 18:47 ` Andrew Lunn
2020-09-30 0:09 ` Jakub Kicinski
2020-09-30 0:16 ` Andrew Lunn [this message]
2020-09-30 15:03 ` ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver) Michal Kubecek
2020-09-30 15:16 ` Andrew Lunn
2020-09-30 15:31 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930001640.GB4012000@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).