From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577CFC2D0A8 for ; Wed, 30 Sep 2020 08:01:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F7F32074A for ; Wed, 30 Sep 2020 08:01:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725908AbgI3IBf (ORCPT ); Wed, 30 Sep 2020 04:01:35 -0400 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:37818 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbgI3IBe (ORCPT ); Wed, 30 Sep 2020 04:01:34 -0400 Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.60]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1F67E60073; Wed, 30 Sep 2020 08:01:32 +0000 (UTC) Received: from us4-mdac16-27.ut7.mdlocal (unknown [10.7.66.59]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1C7A42009A; Wed, 30 Sep 2020 08:01:32 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.199]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8B27B1C0051; Wed, 30 Sep 2020 08:01:31 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DE33618005A; Wed, 30 Sep 2020 08:01:29 +0000 (UTC) Received: from mh-desktop (10.17.20.62) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Sep 2020 09:01:09 +0100 Date: Wed, 30 Sep 2020 09:00:59 +0100 From: Martin Habets To: Thomas Gleixner CC: LKML , Peter Zijlstra , Paul McKenney , Matthew Wilcox , Christian Benvenuti , "Govindarajulu Varadarajan" <_govind@gmx.com>, Dave Miller , "Jakub Kicinski" , , Jonathan Corbet , Mauro Carvalho Chehab , , Sebastian Andrzej Siewior , Luc Van Oostenryck , Jay Cliburn , Chris Snook , "Vishal Kulkarni" , Jeff Kirsher , , Shannon Nelson , Pensando Drivers , Andrew Lunn , "Heiner Kallweit" , Russell King , "Thomas Bogendoerfer" , Solarflare linux maintainers , Edward Cree , "Jon Mason" , Daniel Drake , Ulrich Kunitz , Kalle Valo , , , "Greg Kroah-Hartman" , Arend van Spriel , Franky Lin , "Hante Meuleman" , Chi-Hsien Lin , Wright Feng , , , Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , "Intel Linux Wireless" , Jouni Malinen , "Amitkumar Karwar" , Ganapathi Bhat , Xinming Hu , , Pascal Terjan , Ping-Ke Shih Subject: Re: [patch V2 16/36] net: sfc: Use GFP_KERNEL in efx_ef10_try_update_nic_stats() Message-ID: <20200930080059.GA759845@mh-desktop> Mail-Followup-To: Thomas Gleixner , LKML , Peter Zijlstra , Paul McKenney , Matthew Wilcox , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Dave Miller , Jakub Kicinski , netdev@vger.kernel.org, Jonathan Corbet , Mauro Carvalho Chehab , linux-doc@vger.kernel.org, Sebastian Andrzej Siewior , Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, Shannon Nelson , Pensando Drivers , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Solarflare linux maintainers , Edward Cree , Jon Mason , Daniel Drake , Ulrich Kunitz , Kalle Valo , linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Jouni Malinen , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , libertas-dev@lists.infradead.org, Pascal Terjan , Ping-Ke Shih References: <20200929202509.673358734@linutronix.de> <20200929203501.078203643@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200929203501.078203643@linutronix.de> X-Originating-IP: [10.17.20.62] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-7.055800-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OGB3CLPGH9KvB3Pziq4eLUfcabZ5We+Ltbk1kyQDpEj8OLB DcjMHcx7cY+kGWBLq/yUWq3zEclebye/9tnqvgnhalRqQPhHMT4K+4pGZZRa9Bv2iroWthDcakC rXhKzdtmG9zWd04+U3ToQGsWExzeNQrIARMpKwYGolIr4dI9j7+lUxvXGcRIycBqXYDUNCazpVi VUeZmhdJwA7Oe0sQ7+xGosnG/g3+KtiF+p+9BY6Z4CIKY/Hg3AyJ1gFgOMhOn6APa9i04WGCq2r l3dzGQ12iP5mgvODVRaQUD5lj7we1UZlqkyMlpYV+ioo6EPnD+kB99jpcEJJCvslaXspIjpcQ4u 3HX+lyoF+PYj6P4xsM/gbmgoU/LhYlIrxAazCupFc1SMC3FJkqE7ZT4hHyDpDA2Nf1xiN0z8VRK OCHTcrEMMprcbiest X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.055800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1601452892-t4AssHCSnqUP Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 29, 2020 at 10:25:25PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > efx_ef10_try_update_nic_stats_vf() is now only invoked from thread context > and can sleep after efx::stats_lock is dropped. > > Change the allocation mode from GFP_ATOMIC to GFP_KERNEL. > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner Acked-by: Martin Habets > --- > V2: Adjust to Edward's stats update split > --- > drivers/net/ethernet/sfc/ef10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ethernet/sfc/ef10.c > +++ b/drivers/net/ethernet/sfc/ef10.c > @@ -1873,7 +1873,7 @@ static int efx_ef10_try_update_nic_stats > > efx_ef10_get_stat_mask(efx, mask); > > - rc = efx_nic_alloc_buffer(efx, &stats_buf, dma_len, GFP_ATOMIC); > + rc = efx_nic_alloc_buffer(efx, &stats_buf, dma_len, GFP_KERNEL); > if (rc) { > spin_lock_bh(&efx->stats_lock); > return rc;