From: Ido Schimmel <idosch@idosch.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
jiri@nvidia.com, idosch@nvidia.com
Subject: Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps
Date: Wed, 30 Sep 2020 22:44:07 +0300 [thread overview]
Message-ID: <20200930194407.GA1850258@shredder> (raw)
In-Reply-To: <20200930191645.9520-5-ioana.ciornei@nxp.com>
On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote:
> +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink,
> + const struct devlink_trap *trap,
> + enum devlink_trap_action action,
> + struct netlink_ext_ack *extack)
> +{
> + /* No support for changing the action of an independent packet trap,
> + * only per trap group - parser error drops
> + */
> + return -EOPNOTSUPP;
Please also add an error message via extack
> +}
next prev parent reply other threads:[~2020-09-30 19:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 19:16 [PATCH net-next v2 0/4] dpaa2-eth: add devlink parser error drop trap support Ioana Ciornei
2020-09-30 19:16 ` [PATCH net-next v2 1/4] devlink: add parser error drop packet traps Ioana Ciornei
2020-09-30 19:16 ` [PATCH net-next v2 2/4] devlink: add .trap_group_action_set() callback Ioana Ciornei
2020-09-30 19:53 ` Ido Schimmel
2020-10-01 13:21 ` Ioana Ciornei
2020-09-30 19:16 ` [PATCH net-next v2 3/4] dpaa2-eth: add basic devlink support Ioana Ciornei
2020-09-30 19:16 ` [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps Ioana Ciornei
2020-09-30 19:44 ` Ido Schimmel [this message]
2020-10-01 13:19 ` Ioana Ciornei
2020-10-01 0:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930194407.GA1850258@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=ioana.ciornei@nxp.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).