From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59767C4727C for ; Wed, 30 Sep 2020 19:44:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17FDA2074B for ; Wed, 30 Sep 2020 19:44:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729688AbgI3ToN (ORCPT ); Wed, 30 Sep 2020 15:44:13 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47477 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbgI3ToM (ORCPT ); Wed, 30 Sep 2020 15:44:12 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A30105C012E; Wed, 30 Sep 2020 15:44:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 30 Sep 2020 15:44:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8XGKV3 q5Xzwx82FPNclj487x0cnmgo9nn/1IQcFKS8E=; b=VK1E2yA14dtA+vcOeHHBnQ WX9dXjwEBkVnQxdsIBPMYTt64fWamhB2/g5MVdNVxbPczYMNcKRHmPkpfMFuijeB 7cdPoVF/E/7safW7ObN45l+LVT3UlfWwwU4O/93fdgGjeyGLCpDPjFqnyhepcSCx sfWQ7wNCMOK6NpECNKBek4JMcSsNu79ugOMa3eDUE0kz8s5xJrtGaXNLpJbcctZx RnEft1InZb5r/lZTOZp37zcLzZHvZ2Lw+H3V9ObfihB01xjfPA0mcqrP6zuiRmR2 G90yOpDEm6lPbL8A6WrG5kr26y3rxnkKpsxQAx99+7LJJNKnqjf5NbGnBSh73LpQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfedvgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepkeegrddvvdelrdefjedrudegkeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-37-148.inter.net.il [84.229.37.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 88E6D306467D; Wed, 30 Sep 2020 15:44:10 -0400 (EDT) Date: Wed, 30 Sep 2020 22:44:07 +0300 From: Ido Schimmel To: Ioana Ciornei Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, jiri@nvidia.com, idosch@nvidia.com Subject: Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps Message-ID: <20200930194407.GA1850258@shredder> References: <20200930191645.9520-1-ioana.ciornei@nxp.com> <20200930191645.9520-5-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930191645.9520-5-ioana.ciornei@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote: > +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink, > + const struct devlink_trap *trap, > + enum devlink_trap_action action, > + struct netlink_ext_ack *extack) > +{ > + /* No support for changing the action of an independent packet trap, > + * only per trap group - parser error drops > + */ > + return -EOPNOTSUPP; Please also add an error message via extack > +}