From: David Miller <davem@davemloft.net>
To: colyli@suse.de
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
netdev@vger.kernel.org, open-iscsi@googlegroups.com,
linux-scsi@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, chaitanya.kulkarni@wdc.com,
cleech@redhat.com, hch@lst.de, amwang@redhat.com,
eric.dumazet@gmail.com, hare@suse.de, idryomov@gmail.com,
jack@suse.com, jlayton@kernel.org, axboe@kernel.dk,
lduncan@suse.com, michaelc@cs.wisc.edu,
mskorzhinskiy@solarflare.com, philipp.reisner@linbit.com,
sagi@grimberg.me, vvs@virtuozzo.com, vbabka@suse.com
Subject: Re: [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers
Date: Thu, 01 Oct 2020 12:43:45 -0700 (PDT) [thread overview]
Message-ID: <20201001.124345.2303686561459641833.davem@davemloft.net> (raw)
In-Reply-To: <20201001075408.25508-1-colyli@suse.de>
From: Coly Li <colyli@suse.de>
Date: Thu, 1 Oct 2020 15:54:01 +0800
> This series was original by a bug fix in nvme-over-tcp driver which only
> checked whether a page was allocated from slab allcoator, but forgot to
> check its page_count: The page handled by sendpage should be neither a
> Slab page nor 0 page_count page.
>
> As Sagi Grimberg suggested, the original fix is refind to a more common
> inline routine:
> static inline bool sendpage_ok(struct page *page)
> {
> return (!PageSlab(page) && page_count(page) >= 1);
> }
> If sendpage_ok() returns true, the checking page can be handled by the
> concrete zero-copy sendpage method in network layer.
>
> The v9 series has 7 patches, no change from v8 series,
> - The 1st patch in this series introduces sendpage_ok() in header file
> include/linux/net.h.
> - The 2nd patch adds WARN_ONCE() for improper zero-copy send in
> kernel_sendpage().
> - The 3rd patch fixes the page checking issue in nvme-over-tcp driver.
> - The 4th patch adds page_count check by using sendpage_ok() in
> do_tcp_sendpages() as Eric Dumazet suggested.
> - The 5th and 6th patches just replace existing open coded checks with
...
Series applied and queued up for -stable, thank you.
next prev parent reply other threads:[~2020-10-01 19:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 7:54 [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers Coly Li
2020-10-01 7:54 ` [PATCH v9 1/7] net: introduce helper sendpage_ok() in include/linux/net.h Coly Li
2020-10-01 7:54 ` [PATCH v9 2/7] net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send Coly Li
2020-10-01 7:54 ` [PATCH v9 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage() Coly Li
2020-10-01 7:54 ` [PATCH v9 4/7] tcp: use sendpage_ok() to detect misused .sendpage Coly Li
2020-10-01 7:54 ` [PATCH v9 5/7] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage() Coly Li
2020-10-01 7:54 ` [PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map() Coly Li
2020-10-01 16:10 ` Lee Duncan
2020-10-01 7:54 ` [PATCH v9 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage() Coly Li
2020-10-01 19:43 ` David Miller [this message]
2020-10-01 19:48 ` [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers David Miller
2020-10-02 8:30 ` Coly Li
2020-10-02 22:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001.124345.2303686561459641833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=cleech@redhat.com \
--cc=colyli@suse.de \
--cc=eric.dumazet@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jlayton@kernel.org \
--cc=lduncan@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=mskorzhinskiy@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=vbabka@suse.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).