From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Shannon Nelson <snelson@pensando.io>
Subject: Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update
Date: Thu, 1 Oct 2020 09:17:01 +0200 [thread overview]
Message-ID: <20201001071701.GK8264@nanopsycho> (raw)
In-Reply-To: <20200930234012.137020-1-jacob.e.keller@intel.com>
Thu, Oct 01, 2020 at 01:40:12AM CEST, jacob.e.keller@intel.com wrote:
>For some devices, updating the flash can take significant time during
>operations where no status can meaningfully be reported. This can be
>somewhat confusing to a user who sees devlink appear to hang on the
>terminal waiting for the device to update.
>
>Recent changes to the kernel interface allow such long running commands
>to provide a timeout value indicating some upper bound on how long the
>relevant action could take.
>
>Provide a ticking counter of the time elapsed since the previous status
>message in order to make it clear that the program is not simply stuck.
>
>Display this message whenever the status message from the kernel
>indicates a timeout value. Additionally also display the message if
>we've received no status for more than couple of seconds. If we elapse
>more than the timeout provided by the status message, replace the
>timeout display with "timeout reached".
>
>Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Looks nice. Thanks!
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2020-10-01 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 23:40 [iproute2-next v2 1/1] devlink: display elapsed time during flash update Jacob Keller
2020-10-01 2:18 ` Shannon Nelson
2020-10-01 7:17 ` Jiri Pirko [this message]
2020-10-07 5:56 ` David Ahern
2020-10-12 17:30 ` Keller, Jacob E
2020-10-13 18:24 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001071701.GK8264@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox