From: Vladimir Oltean <olteanv@gmail.com>
To: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
Cc: davem@davemloft.net, f.fainelli@gmail.com,
vivien.didelot@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default
Date: Fri, 2 Oct 2020 11:15:27 +0300 [thread overview]
Message-ID: <20201002081527.d635bjrvr6hhdrns@skbuf> (raw)
In-Reply-To: <87o8llrr0b.fsf@kurt>
On Fri, Oct 02, 2020 at 10:06:28AM +0200, Kurt Kanzenbach wrote:
> Hi Vladimir,
>
> On Tue Sep 08 2020, Vladimir Oltean wrote:
> > On Tue, Sep 08, 2020 at 12:14:12PM +0200, Kurt Kanzenbach wrote:
> >> On Mon Sep 07 2020, Vladimir Oltean wrote:
> >> > New drivers always seem to omit setting this flag, for some reason.
> >>
> >> Yes, because it's not well documented, or is it? Before writing the
> >> hellcreek DSA driver, I've read dsa.rst documentation to find out what
> >> callback function should to what. Did I miss something?
> >
> > Honestly, Documentation/networking/dsa/dsa.rst is out of date by quite a
> > bit. And this trend of having boolean flags in struct dsa_switch started
> > after the documentation stopped being updated.
>
> Maybe it would be good to document new flags when they're introduced :).
Yup, will definitely do that when I resend.
> >
> > But I didn't say it's your fault for not setting the flag, it is easy to
> > miss, and that's what this patch is trying to improve.
> >
> >> > So let's reverse the logic: the DSA core sets it by default to true
> >> > before the .setup() callback, and legacy drivers can turn it off. This
> >> > way, new drivers get the new behavior by default, unless they
> >> > explicitly set the flag to false, which is more obvious during review.
> >>
> >> Yeah, that behavior makes more sense to me. Thank you.
> >
> > Ok, thanks.
>
> Is this merged? I don't see it. Do I have to set
> `configure_vlan_while_not_filtering' explicitly to true for the next
> hellcreek version?
Yes, please set it to true. The refactoring change didn't get merged in
time, I don't want it to interfere with your series.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-10-02 8:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 18:29 [PATCH net-next 0/4] Some VLAN handling cleanup in DSA Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 1/4] net: dsa: tag_8021q: include missing refcount.h Vladimir Oltean
2020-09-08 4:07 ` Florian Fainelli
2020-09-07 18:29 ` [PATCH net-next 2/4] net: dsa: tag_8021q: add a context structure Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 3/4] Revert "net: dsa: Add more convenient functions for installing port VLANs" Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default Vladimir Oltean
2020-09-08 4:07 ` Florian Fainelli
2020-09-08 10:33 ` Vladimir Oltean
2020-09-08 22:28 ` Florian Fainelli
2020-09-09 0:02 ` Florian Fainelli
2020-09-09 16:31 ` Vladimir Oltean
2020-09-09 17:22 ` Florian Fainelli
2020-09-09 17:53 ` Vladimir Oltean
2020-09-09 18:34 ` Florian Fainelli
2020-09-10 21:58 ` Florian Fainelli
2020-09-11 0:03 ` Vladimir Oltean
2020-09-11 3:09 ` Florian Fainelli
2020-09-11 15:43 ` Vladimir Oltean
2020-09-11 18:23 ` Florian Fainelli
2020-09-11 18:35 ` Vladimir Oltean
2020-09-11 19:39 ` Florian Fainelli
2020-09-11 19:48 ` Florian Fainelli
2020-09-11 22:30 ` Vladimir Oltean
2020-09-08 10:14 ` Kurt Kanzenbach
2020-09-08 10:29 ` Vladimir Oltean
2020-10-02 8:06 ` Kurt Kanzenbach
2020-10-02 8:15 ` Vladimir Oltean [this message]
2020-10-03 7:52 ` Vladimir Oltean
2020-10-03 9:45 ` Kurt Kanzenbach
2020-10-04 10:56 ` Vladimir Oltean
2020-10-05 12:34 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002081527.d635bjrvr6hhdrns@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kurt.kanzenbach@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox