From: Stephen Hemminger <stephen@networkplumber.org>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Thomas Davis <tadavis@lbl.gov>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology
Date: Fri, 2 Oct 2020 12:10:51 -0700 [thread overview]
Message-ID: <20201002121051.5ca41c1a@hermes.local> (raw)
In-Reply-To: <20201002174001.3012643-6-jarod@redhat.com>
On Fri, 2 Oct 2020 13:40:00 -0400
Jarod Wilson <jarod@redhat.com> wrote:
> @@ -265,7 +265,7 @@ ad_user_port_key
> This parameter has effect only in 802.3ad mode and is available through
> SysFs interface.
>
> -all_slaves_active
> +all_ports_active
You can change internal variable names, comments, and documentation all you want, thats great.
But you can't change user API, that includes:
* definitions in uapi header
* module parameters
* sysfs file names or outputs
next prev parent reply other threads:[~2020-10-02 19:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 17:39 [PATCH net-next v2 0/6] bonding: rename bond components Jarod Wilson
2020-10-02 17:39 ` [PATCH net-next v2 1/6] bonding: rename 802.3ad's struct port to ad_port Jarod Wilson
2020-10-02 17:39 ` [PATCH net-next v2 2/6] bonding: replace use of the term master where possible Jarod Wilson
2020-10-02 17:39 ` [PATCH net-next v2 3/6] bonding: rename slave to port " Jarod Wilson
2020-10-02 20:20 ` Miguel Ojeda
2020-10-02 17:39 ` [PATCH net-next v2 4/6] bonding: rename bonding_sysfs_slave.c to _port.c Jarod Wilson
2020-10-02 17:40 ` [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology Jarod Wilson
2020-10-02 18:09 ` Andrew Lunn
2020-10-02 20:17 ` Jarod Wilson
2020-10-02 20:43 ` Andrew Lunn
2020-10-02 19:10 ` Stephen Hemminger [this message]
2020-10-02 20:12 ` Jarod Wilson
2020-10-02 22:55 ` David Miller
2020-10-03 19:44 ` Jarod Wilson
2020-10-02 17:40 ` [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces Jarod Wilson
2020-10-02 19:13 ` Stephen Hemminger
2020-10-02 20:23 ` Jarod Wilson
2020-10-02 22:42 ` Stephen Hemminger
2020-10-03 19:50 ` Jarod Wilson
2020-10-02 22:57 ` David Miller
2020-10-03 19:48 ` Jarod Wilson
2020-10-05 17:36 ` Jay Vosburgh
2020-10-02 22:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002121051.5ca41c1a@hermes.local \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tadavis@lbl.gov \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).