From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D24C35257 for ; Fri, 2 Oct 2020 22:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58DDF20719 for ; Fri, 2 Oct 2020 22:42:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="TuBV/giG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725772AbgJBWmg (ORCPT ); Fri, 2 Oct 2020 18:42:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJBWmd (ORCPT ); Fri, 2 Oct 2020 18:42:33 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 681C9C0613E2 for ; Fri, 2 Oct 2020 15:42:31 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id o25so1790510pgm.0 for ; Fri, 02 Oct 2020 15:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0BLzxT6WUemFKsAn6h5mf72t5nn+rCxo/YdzeOflxtE=; b=TuBV/giGUm+Ke8jfXjpm9lJjEbFsrpix4WyKmL0+eHKrqzOskKGGtuihzKU3x4JOmt NXMg9edy5h/Oq2qynIragg/6MIZaneWaPVWdBcM5mOFpD7C9tRSVi5enS1tHN3LiRrA+ pPrwUE1J2Mr2Q7W974fVe847pG9rlbsA27Db+FK57UjFjaJlFS7FjRgk7hxzbYTo6kzR XQfpTuA9UP3TfkdgyiZkudWT8ZYFMFRr/A+7FszxuVC1zv1ROu35xX9dB+B2Ea9hM420 lOVWeQFyqx+iKOmYJ6l9Efa9Hp3cDaApkq+EjcgXHLO6syteI0+EOwrRRnj/YL2y+oqC vHZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0BLzxT6WUemFKsAn6h5mf72t5nn+rCxo/YdzeOflxtE=; b=EjFuuPNLlU6Qq92GUzRxO67BKOS6sgVlgK4Fz1sgBAfnrYQZ314lhKi6JlnPHKQRg6 95Ai+prtQ36ZZ1FAQGPJST9mu3CzAIBIFtyT+ZlLXvREECvrNjK8qerUrdRxgRI+N8wZ 83/G5R0vwGitrodbTENJjGpUoMGrFY3DU5K0XBoBwlLmZCI1g+J1emvSjr7+clYSek1i vlCiyqGNhvMGqGsrcJtulLlF5CqiCdhifJZ+5Ckz0nWz14nT+StgLNfJMRonOFiyOLgX qviSROCgYIx53jpYezfr8hFYnKPJkWVtkw6YEHw0KtgJSUiooueH2RtD/WEPzwEMrpuh Im0w== X-Gm-Message-State: AOAM530XK2LqiLKJrEPH+8Vf4DSzsSALQuVLr2uQAmitZ0uaI9fDQF+H AAEC8pTXb1WA+l1Wy7qh63mKZw== X-Google-Smtp-Source: ABdhPJyu173B+p5Jv1HEkzYuP6VUoCXpC5gB1pWvCRxau9ZNay2HWhBjT/VxkC04+6uuo4g3CvTf2A== X-Received: by 2002:a63:5f89:: with SMTP id t131mr4197704pgb.436.1601678550759; Fri, 02 Oct 2020 15:42:30 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a14sm2579968pju.30.2020.10.02.15.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 15:42:30 -0700 (PDT) Date: Fri, 2 Oct 2020 15:42:22 -0700 From: Stephen Hemminger To: Jarod Wilson Cc: LKML , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Jakub Kicinski , Thomas Davis , Netdev Subject: Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces Message-ID: <20201002154222.3adfe408@hermes.local> In-Reply-To: References: <20201002174001.3012643-1-jarod@redhat.com> <20201002174001.3012643-7-jarod@redhat.com> <20201002121317.474c95f0@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2 Oct 2020 16:23:46 -0400 Jarod Wilson wrote: > On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger > wrote: > > > > On Fri, 2 Oct 2020 13:40:01 -0400 > > Jarod Wilson wrote: > > > > > By default, enable retaining all user-facing API that includes the use of > > > master and slave, but add a Kconfig knob that allows those that wish to > > > remove it entirely do so in one shot. > > > > > > Cc: Jay Vosburgh > > > Cc: Veaceslav Falico > > > Cc: Andy Gospodarek > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Thomas Davis > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Jarod Wilson > > > --- > > > drivers/net/Kconfig | 12 ++++++++++++ > > > drivers/net/bonding/bond_main.c | 4 ++-- > > > drivers/net/bonding/bond_options.c | 4 ++-- > > > drivers/net/bonding/bond_procfs.c | 8 ++++++++ > > > drivers/net/bonding/bond_sysfs.c | 14 ++++++++++---- > > > drivers/net/bonding/bond_sysfs_port.c | 6 ++++-- > > > 6 files changed, 38 insertions(+), 10 deletions(-) > > > > > > > This is problematic. You are printing both old and new values. > > Also every distribution will have to enable it. > > > > This looks like too much of change to users. > > I'd had a bit of feedback that people would rather see both, and be > able to toggle off the old ones, rather than only having one or the > other, depending on the toggle, so I thought I'd give this a try. I > kind of liked the one or the other route, but I see the problems with > that too. > > For simplicity, I'm kind of liking the idea of just not updating the > proc and sysfs interfaces, have a toggle entirely disable them, and > work on enhancing userspace to only use netlink, but ... it's going to > be a while before any such work makes its way to any already shipping > distros. I don't have a satisfying answer here. > I like the idea of having bonding proc and sysf apis optional.