From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>, Wei Wang <weiwan@google.com>,
Network Development <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Paolo Abeni <pabeni@redhat.com>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH net-next 0/5] implement kthread based napi poll
Date: Fri, 2 Oct 2020 21:17:44 -0700 [thread overview]
Message-ID: <20201003041744.zyxp5fx6lbyumvfl@ast-mbp> (raw)
In-Reply-To: <CANn89iLJSHhb=7mibKTBF2bbceFqSM0kNOANdFZ3rTaM3kwj7w@mail.gmail.com>
On Sat, Oct 03, 2020 at 05:54:38AM +0200, Eric Dumazet wrote:
>
> Sure, a WQ is already giving nice results on appliances, because there
> you do not need strong isolation.
> Would a kthread approach also work well on appliances ? Probably...
Right. I think we're on the same page.
The only reason I'm bringing up multiple co-existing approaches now is to make
sure they are designed in from the start instead of as afterthought. Two
implementations already exist, but it doesn't look like that they can co-exist
in the kernel. Like this NAPI_STATE_THREADED bit in this patch set. Should we
burn that bit for kthread approach and another bit for workqueue based?
I don't know. As the user of the feature I would be happy with any mechanism as
long as I can flip between them in runtime :) Just like RPS and RFS.
prev parent reply other threads:[~2020-10-03 4:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 19:21 [PATCH net-next 0/5] implement kthread based napi poll Wei Wang
2020-09-30 19:21 ` [PATCH net-next 1/5] net: implement threaded-able napi poll loop support Wei Wang
2020-09-30 19:21 ` [PATCH net-next 2/5] net: add sysfs attribute to control napi threaded mode Wei Wang
2020-09-30 19:21 ` [PATCH net-next 3/5] net: extract napi poll functionality to __napi_poll() Wei Wang
2020-09-30 19:21 ` [PATCH net-next 4/5] net: modify kthread handler to use __napi_poll() Wei Wang
2020-09-30 19:21 ` [PATCH net-next 5/5] net: improve napi threaded config Wei Wang
2020-10-01 10:01 ` Felix Fietkau
2020-10-01 17:01 ` Wei Wang
2020-10-01 17:11 ` Felix Fietkau
2020-10-01 18:03 ` Eric Dumazet
2020-10-01 18:37 ` Felix Fietkau
2020-10-01 19:24 ` Wei Wang
2020-10-01 20:48 ` Felix Fietkau
2020-10-01 22:42 ` Wei Wang
2020-09-30 20:08 ` [PATCH net-next 0/5] implement kthread based napi poll Jakub Kicinski
2020-10-01 7:52 ` Eric Dumazet
2020-10-01 20:26 ` Jakub Kicinski
2020-10-01 22:12 ` Wei Wang
2020-10-01 23:46 ` Jakub Kicinski
2020-10-02 1:44 ` Wei Wang
2020-10-02 22:53 ` Jakub Kicinski
2020-10-02 7:56 ` Eric Dumazet
2020-10-02 22:49 ` Jakub Kicinski
2020-10-02 23:00 ` David Miller
2020-10-02 23:15 ` Alexei Starovoitov
2020-10-03 3:54 ` Eric Dumazet
2020-10-03 4:17 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003041744.zyxp5fx6lbyumvfl@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox