From: Ido Schimmel <idosch@idosch.org>
To: David Laight <David.Laight@aculab.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"ayal@nvidia.com" <ayal@nvidia.com>,
"mlxsw@nvidia.com" <mlxsw@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [RFC PATCH net-next v2] ethtool: Improve compatibility between netlink and ioctl interfaces
Date: Sun, 4 Oct 2020 16:37:57 +0300 [thread overview]
Message-ID: <20201004133757.GA2189885@shredder> (raw)
In-Reply-To: <07b469aea4494fdeb11f4915459540a4@AcuMS.aculab.com>
On Sun, Oct 04, 2020 at 12:46:31PM +0000, David Laight wrote:
> From: Ido Schimmel
> > Sent: 04 October 2020 11:17
> >
> > With the ioctl interface, when autoneg is enabled, but without
> > specifying speed, duplex or link modes, the advertised link modes are
> > set to the supported link modes by the ethtool user space utility.
> ...
> > Fix this incompatibility problem by introducing a new flag in the
> > ethtool netlink request header: 'ETHTOOL_FLAG_LEGACY'. The purpose of
> > the flag is to indicate to the kernel that it needs to be compatible
> > with the legacy ioctl interface. A patch to the ethtool user space
> > utility will make sure the flag is always set.
>
> You need to do that the other way around.
> You can't assume the kernel and application are updated
> at the same time.
Thanks, David. In case ethtool is updated without updating the kernel we
will indeed get an error:
# ethtool -s eth0 autoneg on
netlink error: unrecognized request flags (offset 36)
netlink error: Operation not supported
Will wait for Michal's comments before doing another round.
next prev parent reply other threads:[~2020-10-04 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 10:17 [RFC PATCH net-next v2] ethtool: Improve compatibility between netlink and ioctl interfaces Ido Schimmel
2020-10-04 12:46 ` David Laight
2020-10-04 13:37 ` Ido Schimmel [this message]
2020-10-05 7:46 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004133757.GA2189885@shredder \
--to=idosch@idosch.org \
--cc=David.Laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).