From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Jonathan McDowell <noodles@earth.li>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers
Date: Sun, 4 Oct 2020 20:59:44 +0000 [thread overview]
Message-ID: <20201004205943.rfblrsivuf47d2m6@skbuf> (raw)
In-Reply-To: <20201002220646.3826555-1-vladimir.oltean@nxp.com>
On Sat, Oct 03, 2020 at 01:06:46AM +0300, Vladimir Oltean wrote:
[...]
> ---
> The API for this one was chosen to be different than the one for
> .port_vlan_add and .port_vlan_prepare because
> (a) the list of dsa_switch_ops is growing bigger but in this case there
> is no justification for it. For example there are some drivers that
> don't do anything in .port_vlan_prepare, and likewise, they may not
> need to do anything in .port_vlan_filtering_prepare either
> (b) the DSA API should be as close as possible to the switchdev API
> except when there's a strong reason for that not to be the case. In
> this situation, I don't see why it would be different.
I understand that this new function prototype is not to everyone's
taste?
next prev parent reply other threads:[~2020-10-04 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 22:06 [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers Vladimir Oltean
2020-10-04 20:59 ` Vladimir Oltean [this message]
2020-10-05 0:45 ` Florian Fainelli
2020-10-05 3:28 ` Florian Fainelli
2020-10-05 13:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004205943.rfblrsivuf47d2m6@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=noodles@earth.li \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox