Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

Bjørn Mork
2020-10-05T10:07:39Z

Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:

> Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
> a patch set. Which is the best way to resubmit an update if the other part of
> the patch set gets accepted? The documentation about re-/submitting patch sets
> is a bit thin.

I see that Johan already has answered this. Just wanted to add that you
don't need to worry about doing anything wrong. It was not my intention
to scare you :-) Fixing up and resending patches is a natural part of
the patch submission process. Don't be afraid to resubmit. The worst
that can happen is that you'll be asked to fix up something else.
That's not a problem.

The most important part is to make it clear that a resubmission replaces
an earlier version of the same patch. This should be visible in the
subject. E.g by using a revision number inside the brackes, like

[PATCH v2] net: qmi_wwan: add Cellient MPL200 card

This tells us that the patch is a revised "v2" of an earlier patch, and
that it replaces "v1". Patches without an explicit revision will then
be assumed to be "v1".

If you are sending a series, then the whole series should usually be
resubmitted with the new revsion number. Even patches without any
changes. The cover letter should then also summarize the changes for
each revisions. But as Johan said: The USB serial and net patches go
through different trees and are therefore best handled as standalone
patches, even if they deal with the same USB composite device.

Bjørn