Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

Wilken Gottwalt
2020-10-04T18:30:55Z

On Sun, 04 Oct 2020 17:29:38 +0200
Bjørn Mork <bjorn@mork.no> wrote:

> Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:
>
> > Add usb ids of the Cellient MPL200 card.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > ---
> > drivers/net/usb/qmi_wwan.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 07c42c0719f5..0bf2b19d5d54 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
>
> This is not a 'usb: serial' driver. Please resend with a less confusing
> subject prefix.
>
> > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
> > {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */
> > {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */
> > {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel
> > E396) */
> > + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm
> > 0x05c6) */
> > { } /* END */
> > };
>
>
> This table is supposed to be organized by device type. The last section
> is for Gobi2k and Gobi3k devices. Please try to put new devices into
> the correct section.

Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
a patch set. Which is the best way to resubmit an update if the other part of
the patch set gets accepted? The documentation about re-/submitting patch sets
is a bit thin.

Will