From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B72C41604 for ; Tue, 6 Oct 2020 05:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65B6F2078A for ; Tue, 6 Oct 2020 05:57:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lIzQwVFz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbgJFF5a (ORCPT ); Tue, 6 Oct 2020 01:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbgJFF5a (ORCPT ); Tue, 6 Oct 2020 01:57:30 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A0A7C0613A7 for ; Mon, 5 Oct 2020 22:57:30 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id p21so1040992pju.0 for ; Mon, 05 Oct 2020 22:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gx4WOvLZE+8XVE2Cbj1TNlsvQN+bEc7hhbjF/tgIFks=; b=lIzQwVFztGvCS46aamlT+Zp90+6vgiZYuYVYPYCJ266iK/uoWXyEyrXdL+ASF2Rpqj ZMXs/jATshsL6nNxJIJtjbFrXbBtj+7EKt0zWl0QpYwJSVFxB/yglLqM6l06tKlgg73j pP+effqg9e6dsJyuFUrqtstsMcZCr/eCqWXu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gx4WOvLZE+8XVE2Cbj1TNlsvQN+bEc7hhbjF/tgIFks=; b=JuaVXw1YoOQLFrbkKrdF4kPPHFRX0g8ZYW3Jq7XiNxN65Ez6pWnegsRMa7NeUmoA+q Ha+eUgFAyijjkdZe6BVjEWIdskwo1GIGtnb4YfZPDN+Yu+2jzQue2dq4fo5NcXt7wV+h ueL9qjrmraMDleK7YgpjFSXghuu22qv9joRb/VF5PC6z+h1WBhkCiZlPfKSRsrTW2Vlq siUQgZYjSwO7c/EYO+ZGJqwyYPinLsUwz5vs5DAcnGaWocLOJFpOgDLdyDMesnENeA97 leqdibPg3HzMBWWcDUYUd9zUt3y2JQ4gMnGj/3F2ugM/qhcFeoo+XLB+2RrWqvV/n5n+ 60kg== X-Gm-Message-State: AOAM533ensYO+gGjEUniS4Ss0DN9jN78bVeAx2MYPr05VwtDzjhyNF9O /1B29MvXRj/81nSAaKFjLxrtwA== X-Google-Smtp-Source: ABdhPJyyhqIDHGy7mDnDHpQB09ZhAu+H7/Ucq2xIm6TB1CInHA8Hx4CXWDmYBVa2VyTjeL4m+tfnaA== X-Received: by 2002:a17:90a:8007:: with SMTP id b7mr274521pjn.84.1601963849512; Mon, 05 Oct 2020 22:57:29 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y126sm1607049pgb.40.2020.10.05.22.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 22:57:28 -0700 (PDT) Date: Mon, 5 Oct 2020 22:57:27 -0700 From: Kees Cook To: Willy Tarreau Cc: Thibaut Sautereau , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, Thibaut Sautereau , Linus Torvalds , Emese Revfy , Theodore Ts'o , Andrew Morton Subject: Re: [PATCH] random32: Restore __latent_entropy attribute on net_rand_state Message-ID: <202010052257.CB8E47E@keescook> References: <20201002151610.24258-1-thibaut.sautereau@clip-os.org> <202010051910.BC7E9F4@keescook> <20201006022808.GA5531@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201006022808.GA5531@1wt.eu> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 06, 2020 at 04:28:09AM +0200, Willy Tarreau wrote: > Hi Kees, > > On Mon, Oct 05, 2020 at 07:12:29PM -0700, Kees Cook wrote: > > On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote: > > > From: Thibaut Sautereau > > > > > > Commit f227e3ec3b5c ("random32: update the net random state on interrupt > > > and activity") broke compilation and was temporarily fixed by Linus in > > > 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy > > > gcc plugin") by entirely moving net_rand_state out of the things handled > > > by the latent_entropy GCC plugin. > > > > > > From what I understand when reading the plugin code, using the > > > __latent_entropy attribute on a declaration was the wrong part and > > > simply keeping the __latent_entropy attribute on the variable definition > > > was the correct fix. > > > > > > Fixes: 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy gcc plugin") > > > Cc: Linus Torvalds > > > Cc: Willy Tarreau > > > Cc: Emese Revfy > > > Signed-off-by: Thibaut Sautereau > > > > Yes, that looks correct. Thank you! > > > > Acked-by: Kees Cook > > > > I'm not sure the best tree for this. Ted, Andrew, Linus? I'll take it > > via my gcc plugin tree if no one else takes it. :) > > It was already merged as commit 09a6b0bc3be79 and queued for -stable. Ah, perfect! Thanks. -- Kees Cook