From: Jiri Pirko <jiri@resnulli.us>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>,
davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com,
nikolay@nvidia.com, jiri@mellanox.com, idosch@mellanox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, UNGLinuxDriver@microchip.com,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation
Date: Tue, 6 Oct 2020 11:02:03 +0200 [thread overview]
Message-ID: <20201006090203.GA3336@nanopsycho> (raw)
In-Reply-To: <20201005130712.ybbgiddb7bnbkz6h@ws.localdomain>
Mon, Oct 05, 2020 at 03:07:12PM CEST, allan.nielsen@microchip.com wrote:
>Hi Jiri
>
>On 01.10.2020 14:49, Jiri Pirko wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernlund@microchip.com wrote:
>> > This is the definition of the CFM switchdev interface.
>> >
>> > The interface consist of these objects:
>> > SWITCHDEV_OBJ_ID_MEP_CFM,
>> > SWITCHDEV_OBJ_ID_MEP_CONFIG_CFM,
>> > SWITCHDEV_OBJ_ID_CC_CONFIG_CFM,
>> > SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM,
>> > SWITCHDEV_OBJ_ID_CC_CCM_TX_CFM,
>> > SWITCHDEV_OBJ_ID_MEP_STATUS_CFM,
>> > SWITCHDEV_OBJ_ID_PEER_MEP_STATUS_CFM
>> >
>> > MEP instance add/del
>> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_MEP_CFM)
>> > switchdev_port_obj_del(SWITCHDEV_OBJ_ID_MEP_CFM)
>> >
>> > MEP cofigure
>> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_MEP_CONFIG_CFM)
>> >
>> > MEP CC cofigure
>> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_CONFIG_CFM)
>> >
>> > Peer MEP add/del
>> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM)
>> > switchdev_port_obj_del(SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM)
>> >
>> > Start/stop CCM transmission
>> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_CCM_TX_CFM)
>> >
>> > Get MEP status
>> > switchdev_port_obj_get(SWITCHDEV_OBJ_ID_MEP_STATUS_CFM)
>> >
>> > Get Peer MEP status
>> > switchdev_port_obj_get(SWITCHDEV_OBJ_ID_PEER_MEP_STATUS_CFM)
>> >
>> > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>> > Signed-off-by: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
>>
>> You have to submit the driver parts as a part of this patchset.
>> Otherwise it is no good.
>Fair enough.
>
>With MRP we did it like this, and after Nik asked for details on what is
>being offload, we thought that adding this would help.
>
>The reason why we did not include the implementation of this interface
>is that it is for a new SoC which is still not fully available which is
>why we have not done the basic SwitchDev driver for it yet. But the
>basic functionality clearly needs to come first.
>
>Our preference is to continue fixing the comments we got on the pure SW
>implementation and then get back to the SwitchDev offloading.
>
>This will mean dropping the last 2 patches in the serie.
>
>Does that work for you Jiri, and Nik?
Sure.
>
>/Allan
>
next prev parent reply other threads:[~2020-10-06 9:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 10:30 [net-next v2 00/11] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Henrik Bjoernlund
2020-10-01 10:30 ` [net-next v2 01/11] net: bridge: extend the process of special frames Henrik Bjoernlund
2020-10-01 16:31 ` kernel test robot
2020-10-01 18:02 ` kernel test robot
2020-10-01 18:36 ` kernel test robot
2020-10-06 14:13 ` Nikolay Aleksandrov
2020-10-01 10:30 ` [net-next v2 02/11] bridge: cfm: Add BRIDGE_CFM to Kconfig Henrik Bjoernlund
2020-10-01 10:30 ` [net-next v2 03/11] bridge: uapi: cfm: Added EtherType used by the CFM protocol Henrik Bjoernlund
2020-10-01 10:30 ` [net-next v2 04/11] bridge: cfm: Kernel space implementation of CFM Henrik Bjoernlund
2020-10-06 14:29 ` Nikolay Aleksandrov
2020-10-01 10:30 ` [net-next v2 05/11] " Henrik Bjoernlund
2020-10-01 10:30 ` [net-next v2 06/11] " Henrik Bjoernlund
2020-10-01 10:30 ` [net-next v2 07/11] bridge: cfm: Netlink Interface Henrik Bjoernlund
2020-10-06 14:44 ` Nikolay Aleksandrov
2020-10-01 10:30 ` [net-next v2 08/11] bridge: cfm: Netlink Notifications Henrik Bjoernlund
2020-10-06 14:49 ` Nikolay Aleksandrov
2020-10-01 10:30 ` [net-next v2 09/11] bridge: cfm: Bridge port remove Henrik Bjoernlund
2020-10-06 14:53 ` Nikolay Aleksandrov
2020-10-01 10:30 ` [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation Henrik Bjoernlund
2020-10-01 12:49 ` Jiri Pirko
2020-10-05 13:07 ` Allan W. Nielsen
2020-10-06 9:02 ` Jiri Pirko [this message]
2020-10-06 10:50 ` Nikolay Aleksandrov
2020-10-06 10:53 ` allan.nielsen
2020-10-01 15:20 ` kernel test robot
2020-10-01 15:38 ` kernel test robot
2020-10-01 10:30 ` [net-next v2 11/11] bridge: cfm: Added CFM switchdev utilization Henrik Bjoernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006090203.GA3336@nanopsycho \
--to=jiri@resnulli.us \
--cc=UNGLinuxDriver@microchip.com \
--cc=allan.nielsen@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=henrik.bjoernlund@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).