From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD41C4727D for ; Tue, 6 Oct 2020 19:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC6A620796 for ; Tue, 6 Oct 2020 19:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602012041; bh=gTi6TGQ5uGxOAlj1bghUBAh7jPkrXH4Z6wm41afuJzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=g+zbKGnIEOk+Thk/ljn5CNYittmxCRP6Kb4aawBi19Vyygylw0G0JdWIaDqkzNprN Xs5J38xfOeIJgS5cD+fRPVYD8eRzLZTA4ol1Bq47O5gOiPYZjuD0ftrE22z8ixhWrS moPHuf7E4/wvMf3htJGl34gUWuzeyRiwLhFDopeU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbgJFTUl (ORCPT ); Tue, 6 Oct 2020 15:20:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:53694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726981AbgJFTUk (ORCPT ); Tue, 6 Oct 2020 15:20:40 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91BE4206B5; Tue, 6 Oct 2020 19:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602012040; bh=gTi6TGQ5uGxOAlj1bghUBAh7jPkrXH4Z6wm41afuJzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0YmRzaEwDk60OeBAZemGG0lHKcBt/TDRMOeymj0dVaYr1u1Pv4BPjlkrBKLhMjfDm vxpyhRvnLGoBIBG4iprzsUPAoCSF52TsNVJ/Oq+mZG9LkyYVv21QEMUchasaxFSvpy R2cjN4J2qumXijg7yszKmCXmcTbFuEdlH5xozb1Y= Date: Tue, 6 Oct 2020 22:20:36 +0300 From: Leon Romanovsky To: "Saleem, Shiraz" Cc: Parav Pandit , Pierre-Louis Bossart , "Ertman, David M" , "alsa-devel@alsa-project.org" , "parav@mellanox.com" , "tiwai@suse.de" , "netdev@vger.kernel.org" , "ranjani.sridharan@linux.intel.com" , "fred.oh@linux.intel.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , "broonie@kernel.org" , Jason Gunthorpe , "gregkh@linuxfoundation.org" , "kuba@kernel.org" , "Williams, Dan J" , "davem@davemloft.net" , "Patil, Kiran" Subject: Re: [PATCH v2 1/6] Add ancillary bus support Message-ID: <20201006192036.GQ1874917@unreal> References: <20201005182446.977325-1-david.m.ertman@intel.com> <20201005182446.977325-2-david.m.ertman@intel.com> <20201006071821.GI1874917@unreal> <20201006170241.GM1874917@unreal> <20201006172650.GO1874917@unreal> <3ff1445d86564ef3aae28d1d1a9a19ea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ff1445d86564ef3aae28d1d1a9a19ea@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 06, 2020 at 05:41:00PM +0000, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > On Tue, Oct 06, 2020 at 05:09:09PM +0000, Parav Pandit wrote: > > > > > > > From: Leon Romanovsky > > > > Sent: Tuesday, October 6, 2020 10:33 PM > > > > > > > > On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote: > > > > > Thanks for the review Leon. > > > > > > > > > > > > Add support for the Ancillary Bus, ancillary_device and ancillary_driver. > > > > > > > It enables drivers to create an ancillary_device and bind an > > > > > > > ancillary_driver to it. > > > > > > > > > > > > I was under impression that this name is going to be changed. > > > > > > > > > > It's part of the opens stated in the cover letter. > > > > > > > > ok, so what are the variants? > > > > system bus (sysbus), sbsystem bus (subbus), crossbus ? > > > Since the intended use of this bus is to > > > (a) create sub devices that represent 'functional separation' and > > > (b) second use case for subfunctions from a pci device, > > > > > > I proposed below names in v1 of this patchset. > > > > > > (a) subdev_bus > > > > It sounds good, just can we avoid "_" in the name and call it subdev? > > > > What is wrong with naming the bus 'ancillary bus'? I feel it's a fitting name. > An ancillary software bus for ancillary devices carved off a parent device registered on a primary bus. Greg summarized it very well, every internal conversation about this patch with my colleagues (non-english speakers) starts with the question: "What does ancillary mean?" https://lore.kernel.org/alsa-devel/20201001071403.GC31191@kroah.com/ "For non-native english speakers this is going to be rough, given that I as a native english speaker had to go look up the word in a dictionary to fully understand what you are trying to do with that name." Thanks > > >